chore: rely only on span status code for hasError

SigNoz · Nov 23, 2023 · 926fba7 · 926fba7
1 parent ae589d9
commit 926fba7
Showing 1 changed file with 0 additions and 6 deletions.
diff --git a/exporter/clickhousetracesexporter/clickhouse_exporter.go b/exporter/clickhousetracesexporter/clickhouse_exporter.go
@@ -157,9 +157,6 @@ func populateOtherDimensions(attributes pcommon.Map, span *Span) {
 			if err == nil && statusString != 0 {
 				statusInt = int64(statusString)
 			}
-			if statusInt >= 500 || (statusInt >= 400 && span.Kind != 2) {
-				span.HasError = true
-			}
 			span.HttpCode = strconv.FormatInt(statusInt, 10)
 			span.ResponseStatusCode = span.HttpCode
 		} else if k == "http.url" && span.Kind == 3 {
@@ -202,9 +199,6 @@ func populateOtherDimensions(attributes pcommon.Map, span *Span) {
 			if err == nil && statusString != 0 {
 				statusInt = int64(statusString)
 			}
-			if statusInt >= 2 {
-				span.HasError = true
-			}
 			span.GRPCCode = strconv.FormatInt(statusInt, 10)
 			span.ResponseStatusCode = span.GRPCCode
 		} else if k == "rpc.method" {