fix: hasError not set true #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for server kind spans with 4xx errors
makeavish
requested review from
ankitnayan,
nityanandagohain,
prashant-shahi and
srikanthccv
as code owners
srikanthccv
reviewed
Jun 26, 2023
|
As discussed on 26th Jun, Please rely on the span status code for hasError. |
@srikanthccv Updated code to only rely on span status code for has error. Here we are checking if span status code is 2 to set hasError to true |
|
Can you use the symbol |
Updated |
srikanthccv
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for server kind spans with 4xx errors
fixes(#147)