Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#167 update dependencies #168

Closed
wants to merge 0 commits into from
Closed

#167 update dependencies #168

wants to merge 0 commits into from

Conversation

svsk417
Copy link

@svsk417 svsk417 commented Aug 21, 2023

Closes #167

@svsk417
Copy link
Author

svsk417 commented Aug 21, 2023

Hi! I tested this as good as I could. I executed the go application and it did the migrations etc. But I am not very proficient in Go, so please review carefully.
I left the dependency github.com/open-telemetry/opentelemetry-collector-contrib/receiver/dotnetdiagnosticsreceiver v0.76.3 in place, as there was no new version and prometheusexecreceiver at 0.82.0, since it was deprecated and no version 0.83.0 was published

@svsk417
Copy link
Author

svsk417 commented Aug 24, 2023

The build is failing, because the CI uses go version 1.19 and I tested it locally with 1.21.
The function errors.join was introduced in go 1.20 and therefore cannot be found. I updated the actions to use 1.21

@svsk417
Copy link
Author

svsk417 commented Aug 24, 2023

Hi @prashant-shahi!
Can you trigger another build?
Let's see, if it works now :)

@svsk417
Copy link
Author

svsk417 commented Aug 29, 2023

Hi @prashant-shahi,
can you take a look at this? :)

@prashant-shahi
Copy link
Member

prashant-shahi commented Sep 19, 2023

Hi @svsk417, apologies for late response.

About the linked issue and the PR, usually, we have thorough internal tests before bumping up to new OtelCollector version.

This is critical to not only making it work for SigNoz cluster to run properly.
But also users who might have external clients still running on older version of OtelCollectors.

Nevertheless, let me share the PR and linked issue with the maintainers of the repository.

@svsk417
Copy link
Author

svsk417 commented Sep 20, 2023

Hi @prashant-shahi, I deleted my changes since opentelemetry-collector-contrib version 0.85.0 has been released. It would be nice, if you bump to that version. :) If I shall do another PR with that version just let me know. I will be waiting for your response before beginning to not have merge conflicts making the PR obsolete.

@prashant-shahi
Copy link
Member

@svsk417 Continuing the conversation in the issue thread: #167 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Open telemetry contrib packages to 0.80.0
2 participants