-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for new logs schema #348
Conversation
migrationmanager/migrators/logs/migrations/000014_new_schema.up.sql
Outdated
Show resolved
Hide resolved
migrationmanager/migrators/logs/migrations/000014_new_schema.up.sql
Outdated
Show resolved
Hide resolved
migrationmanager/migrators/logs/migrations/000014_new_schema.up.sql
Outdated
Show resolved
Hide resolved
migrationmanager/migrators/logs/migrations/000014_new_schema.up.sql
Outdated
Show resolved
Hide resolved
migrationmanager/migrators/logs/migrations/000014_new_schema.up.sql
Outdated
Show resolved
Hide resolved
migrationmanager/migrators/logs/migrations/000014_new_schema.up.sql
Outdated
Show resolved
Hide resolved
migrationmanager/migrators/logs/migrations/000014_new_schema.up.sql
Outdated
Show resolved
Hide resolved
Two more things I wanted to point out.
https://clickhouse.com/docs/en/sql-reference/operators/in
|
Major changes made
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
migrationmanager/migrators/logs/migrations/000014_new_schema.up.sql
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking point
New logs schema
fixes SigNoz/signoz#5555
---- testing /running
go run cmd/signozschemamigrator/migrate.go --dsn http://localhost:9000 --replication true