Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add skywalking receiver #35

Merged
merged 2 commits into from
Aug 4, 2023
Merged

Conversation

makeavish
Copy link
Member

No description provided.

Copy link
Member

@prashant-shahi prashant-shahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@nityanandagohain nityanandagohain removed their request for review August 4, 2023 04:36
@srikanthccv
Copy link
Member

I remembered this existed. @makeavish was there any reason why we didn't merge this? We can merge this and release a minor version. And then we can tell skywalking users to use this.

@makeavish
Copy link
Member Author

I remembered this existed. @makeavish was there any reason why we didn't merge this? We can merge this and release a minor version. And then we can tell skywalking users to use this.

I don't remember the reason to not to merge it. Let me update this.

@makeavish makeavish merged commit dc03b7c into main Aug 4, 2023
3 checks passed
@makeavish makeavish deleted the feat/add-skywalking-receiver branch August 4, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants