Add pre-aggregation tables with 5m and 30m resolution for samples v4 #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srikanthccv
requested review from
ankitnayan,
makeavish,
nityanandagohain and
prashant-shahi
as code owners
ankitnayan
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The supported temporal aggregation in metrics are
This change adds a pre-aggregated table with
The
avgwill be calculated usingsum/count. We don't support count distinct because it is rarely used and doesn't need pre-aggregation wherever it is used.Please see https://www.notion.so/signoz/Metrics-samples-aggregation-tables-71db1d3ac3724f5ba693e0e99eb352ce for additional detail and how the queries would be written on these tables.