Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signozlogspipelineprocessor: use own copy of stanza operators #403

Merged

Conversation

raj-k-singh
Copy link
Contributor

@raj-k-singh raj-k-singh commented Sep 16, 2024

Brings in copies of stanza pieces relevant to logs pipelines from opentelemetry-collector-config at processor/signozlogspipelineprocessor/stanza/

Bringing over pieces of stanza will give us the ability to modify anything and everything as needed to achieve our goals with logs pipelines

Almost all of the files in this PR have been brought in as is with no/minimal modifications and have a comment stating the same in their 1st line

contributes to SigNoz/signoz#5894 and SigNoz/signoz#4444

@srikanthccv
Copy link
Member

Excluding the code that has been brought in as is, I see a major change as signozlogspipelineprocessor/stanza/operator. Can you help me understand what is the difference b/w processor/signozlogspipelineprocessor/stanza/operator and opentelemetry-collector-contrib/pkg/stanza/operator?

@raj-k-singh
Copy link
Contributor Author

raj-k-singh commented Sep 18, 2024

Excluding the code that has been brought in as is, I see a major change as signozlogspipelineprocessor/stanza/operator. Can you help me understand what is the difference b/w processor/signozlogspipelineprocessor/stanza/operator and opentelemetry-collector-contrib/pkg/stanza/operator?

We want to use our own copies of stanza operators to allow us to modify their code - the relevant stanza operators have been copied over to processor/signozlogspipelineprocessor/stanza/operator/operators
To make the logspipeline processor use these copies instead of the ones in stanza, we also need to maintain our own registry of these copied operators that get used when unmarshalling the config
Other than the copies of operators at signozlogspipelineprocessor/stanza/operator/operators, our own operator registry signozlogspipelineprocessor/stanza/operator/registry.go and our own operator config that uses that registry instead of the opentelemetry-collector-contrib one signozlogspipelineprocessor/stanza/operator/config.go are the only changes included in signozlogspipelineprocessor/stanza/operator

@raj-k-singh raj-k-singh merged commit 2d00bb9 into main Sep 19, 2024
3 checks passed
@raj-k-singh raj-k-singh deleted the signozlogspipelineprocessor-use-own-copy-of-stanza-operators branch September 19, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants