Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wire up the components with main #59

Merged
merged 39 commits into from
Sep 26, 2023
Merged

Wire up the components with main #59

merged 39 commits into from
Sep 26, 2023

Conversation

srikanthccv
Copy link
Member

Part of SigNoz/signoz#1786

See first #57

This PR wires up the service package with the main package, make all components glued up, and enables the collector to run as a remote-controlled agent.

Base automatically changed from service to main March 6, 2023 20:14
@nityanandagohain nityanandagohain marked this pull request as ready for review March 22, 2023 05:49
@srikanthccv
Copy link
Member Author

@rkssisodiya This has the following changes besides the piecing together OpAMP with the main

  • wait indefinitely until the collector receives the first config
  • restart the collector even if the config hasn’t changed for the first time (the OpAMP server may not have anything new to offer)
  • handle some async errors from the collector service
  • make OpAMP optional when the manager config (i.e Server URL) is not provided

cmd/signozcollector/Dockerfile.old Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@srikanthccv
Copy link
Member Author

@rkssisodiya I resolved the comments and did some cleanup. Please take another look. This is also good for testing/using. Let me know if there are any issues.

@srikanthccv srikanthccv enabled auto-merge (squash) September 26, 2023 16:50
@srikanthccv srikanthccv merged commit 24cf1da into main Sep 26, 2023
2 checks passed
@srikanthccv srikanthccv deleted the glue-up branch October 22, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants