-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Delta temporality #2505
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srikanthccv
changed the title
Delta temporality preview
Add support for Delta temporality
Jul 10, 2023
ankitnayan
reviewed
Jul 13, 2023
ankitnayan
reviewed
Jul 13, 2023
ankitnayan
previously approved these changes
Jul 13, 2023
ankitnayan
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2405
Fixes #1707
Enable using
--prefer-delta
CLI flag.The delta temporality is low on memory, and programs with strict memory constraints use delta.
Corresponding collector PR SigNoz/signoz-otel-collector#121
Let's look at the example data for a metric
http_requests_count
with different temporalities.Assume
The request
rate
with a step interval of '15'sFor the cumulative temporality, we take the highest value at the timestamp and calculate the running difference of the value
and for delta it will be sum of the values in the step interval group.
Use the following script to generate the above equivalent data.
app.py
requirements.txt
Run the program for some time and try charting the
SUM_RATE
for both metrics.