You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the attribute erichment is happening at the time of query preparation. This means we should pass keys all the way down which makes the whole call require passing keys. This commit removes it from params and enriches the attribute prior like we do for logs.
Code Refactor The removal of the keys parameter from the QueryRange method simplifies the method signature and potentially improves maintainability. However, it's crucial to ensure that all functionalities related to attribute keys are preserved or properly handled elsewhere in the codebase.
Code Refactor The removal of the keys parameter from various methods like runBuilderQuery and runBuilderExpression simplifies the method signatures. Ensure that the functionality related to these keys is either no longer needed or is handled appropriately elsewhere.
Code Refactor The QueryRange method's signature has been simplified by removing the keys parameter. This change should be thoroughly tested to ensure that it does not affect the functionality of querying and that any necessary attribute key handling is performed before this point.
Code Refactor The removal of keys from methods like getColumnName and buildTracesQuery could simplify the code but requires careful consideration to ensure that all functionalities related to the keys are correctly handled or are no longer necessary.
@makeavish the linked issue won't be solved by this yet. The keys are still loaded every time for query range request. This refactor streamlines things so that alerts and query range perform attribute enrichment upfront.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently, the attribute erichment is happening at the time of query preparation. This means we should pass keys all the way down which makes the whole call require passing keys. This commit removes it from params and enriches the attribute prior like we do for logs.