Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port drive subsystem to command robot #58

Merged
merged 12 commits into from
Jan 6, 2024

Conversation

IanTapply22
Copy link
Member

Description

  • Updated the drive-related dependencies to the latest beta
  • Updated drive telemetry to the new CTRE suggested way
  • Created a new drive subsystem and deleted the old one

Fixes #8

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

N/A

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation, if any
  • My changes generate no new warnings
  • I have performed tests that prove my fix is effective or that my feature works, if necessary
  • New and existing unit tests pass locally with my changes

Updated drive telemetry and created a new drive subsystem
@IanTapply22 IanTapply22 added the enhancement New feature or request label Jan 4, 2024
@IanTapply22 IanTapply22 self-assigned this Jan 4, 2024
Copy link

github-actions bot commented Jan 4, 2024

Thank you for making a pull request! Please make sure to follow the pull request guidelines for this PR. This applies to your commit messages, pull request code, and more!

@IanTapply22 IanTapply22 linked an issue Jan 4, 2024 that may be closed by this pull request
@IanTapply22 IanTapply22 marked this pull request as ready for review January 6, 2024 00:29
@IanTapply22
Copy link
Member Author

So far I think it's good to be reviewed code wise, I still have a README in the works though so stay tuned.

@kaleb-dodd kaleb-dodd merged commit b269ec6 into 2024-beta Jan 6, 2024
@kaleb-dodd kaleb-dodd deleted the 8/port-drive-subsystem-to-command-robot branch January 6, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port drive subsystem to command robot
2 participants