Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform-independent way to build path for fonts into the sample. Now… #371

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

snechaev
Copy link
Contributor

… should work on non-Windows systems.

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

The DrawWithImageSharp were crashing on macos/net6 with the System.IO.FileNotFoundException while adding a fonts from files with the paths like the /Users/user/work/Fonts/artifacts/bin/samples/DrawWithImageSharp/Debug/net6.0/Fonts\\SixLaborsSampleAB.ttf (note the \\ delimiter before the file name). This pull request uses the Path.Combine to build the paths, so the correct platform-specific path delimiters are used.

@CLAassistant
Copy link

CLAassistant commented Dec 19, 2023

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e0eb503) 86% compared to head (1b4c949) 86%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #371   +/-   ##
=====================================
  Coverage     86%     86%           
=====================================
  Files        238     238           
  Lines      15184   15184           
  Branches    2101    2101           
=====================================
  Hits       13088   13088           
  Misses      1613    1613           
  Partials     483     483           
Flag Coverage Δ
unittests 86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@JimBobSquarePants JimBobSquarePants merged commit 4c88253 into SixLabors:main Jan 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants