Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added BlobContainerClientProvider option to AzureBlobStorageCache and AzureBlobStorageImageProvider #361

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

marklagendijk
Copy link
Contributor

@marklagendijk marklagendijk commented Mar 14, 2024

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Implementation of #360

…geCache and AzureBlobStorageImageProvider.cs
@marklagendijk marklagendijk changed the title Feature: Added BlobContainerClientProvider option to AzureBlobStorageCache and AzureBlobStorageImageProvider Feature: Added BlobContainerClientProvider option to AzureBlobStorageCache and AzureBlobStorageImageProvider Mar 14, 2024
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 85%. Comparing base (46068c2) to head (3bb469c).
Report is 2 commits behind head on main.

Files Patch % Lines
...b.Providers.Azure/Caching/AzureBlobStorageCache.cs 75% 0 Missing and 1 partial ⚠️
...s.Azure/Providers/AzureBlobStorageImageProvider.cs 83% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@         Coverage Diff         @@
##           main   #361   +/-   ##
===================================
- Coverage    85%    85%   -1%     
===================================
  Files        82     82           
  Lines      2343   2349    +6     
  Branches    350    352    +2     
===================================
+ Hits       2012   2016    +4     
  Misses      230    230           
- Partials    101    103    +2     
Flag Coverage Δ
unittests 85% <83%> (-1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant