Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix headers #39

Merged
merged 1 commit into from
Nov 11, 2024
Merged

fix headers #39

merged 1 commit into from
Nov 11, 2024

Conversation

wtfdivyansh
Copy link
Contributor

@wtfdivyansh wtfdivyansh commented Nov 11, 2024

Summary by CodeRabbit

  • New Features

    • Enhanced CORS configuration to support secure connections by updating allowed origins to HTTPS.
    • Introduced a new asynchronous method for setting HTTP headers in the Next.js configuration, improving API route security.
  • Bug Fixes

    • Corrected the protocol for one of the allowed origins to ensure secure requests are accepted.

Copy link

coderabbitai bot commented Nov 11, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request involve updates to the CORS configuration for a Next.js application. In the route.ts file, the protocol for one of the allowed origins is changed from HTTP to HTTPS. Additionally, the next.config.js file introduces a new asynchronous method for setting HTTP headers, enhancing the CORS capabilities for API routes. These modifications do not affect the existing logic or functionality of the application.

Changes

File Change Summary
apps/api/app/api/[[...route]]/route.ts Updated allowed origin from "http://app.plura.pro" to "https://app.plura.pro" in CORS settings.
apps/api/next.config.js Added an asynchronous headers method for setting CORS headers for API routes; minor ESLint reformatting.

Possibly related PRs

  • feature/auth #33: Modifications to the route.ts file related to the handling of the OPTIONS method and CORS configuration, relevant to the changes in this PR.
  • auth #34: Changes in the route.ts file focusing on the OPTIONS handler and CORS middleware configuration, closely linked to the main PR's CORS settings.

🐰 In the meadow, changes bloom,
CORS now sings a safer tune.
From HTTP to HTTPS we glide,
With headers set, our paths collide.
A hop, a skip, through routes we flow,
In harmony, our APIs grow! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

vercel bot commented Nov 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plura-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2024 1:53pm
plura-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2024 1:53pm

Copy link

vercel bot commented Nov 11, 2024

@wtfdivyansh is attempting to deploy a commit to the BlueFinZ Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants