Sweep: fix: git pull on downloaded plugin does not working (✓ Sandbox Passed)
#372
sweep-ai[bot]Annotations
8 warnings
|
use of `expect` followed by a function call:
fluere-plugin/src/lib.rs#L273
warning: use of `expect` followed by a function call
--> fluere-plugin/src/lib.rs:273:22
|
273 | .expect(format!("Error on plugin: {}", plugin_name).as_str());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Error on plugin: {}", plugin_name))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
|
|
use of `expect` followed by a function call:
fluere-plugin/src/lib.rs#L234
warning: use of `expect` followed by a function call
--> fluere-plugin/src/lib.rs:234:34
|
234 | ... .expect(format!("Error on plugin: {}", plugin_name).as_str());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Error on plugin: {}", plugin_name))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
|
|
use of `expect` followed by a function call:
fluere-plugin/src/lib.rs#L223
warning: use of `expect` followed by a function call
--> fluere-plugin/src/lib.rs:223:30
|
223 | ... .expect(format!("Failed to set key: {}", key).as_str());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Failed to set key: {}", key))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
= note: `#[warn(clippy::expect_fun_call)]` on by default
|
|
using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)`:
fluere-plugin/src/downloader.rs#L17
warning: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)`
--> fluere-plugin/src/downloader.rs:17:30
|
17 | let mut origin = repo.find_remote("origin").or_else(|_| {
| ______________________________^
18 | | Err(io::Error::new(
19 | | io::ErrorKind::Other,
20 | | "Remote 'origin' does not exist",
21 | | ))
22 | | })?;
| |______________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map
= note: `#[warn(clippy::bind_instead_of_map)]` on by default
help: try
|
17 ~ let mut origin = repo.find_remote("origin").map_err(|_| io::Error::new(
18 + io::ErrorKind::Other,
19 + "Remote 'origin' does not exist",
20 ~ ))?;
|
|
|
unused variable: `cd_cmd`:
fluere-plugin/src/downloader.rs#L9
warning: unused variable: `cd_cmd`
--> fluere-plugin/src/downloader.rs:9:9
|
9 | let cd_cmd = format!("cd {}", path.display());
| ^^^^^^ help: if this is intentional, prefix it with an underscore: `_cd_cmd`
|
= note: `#[warn(unused_variables)]` on by default
|
|
this import is redundant:
fluere-plugin/src/downloader.rs#L2
warning: this import is redundant
--> fluere-plugin/src/downloader.rs:2:1
|
2 | use git2;
| ^^^^^^^^^ help: remove it entirely
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
= note: `#[warn(clippy::single_component_path_imports)]` on by default
|
|
this function has too many arguments (27/7):
fluereflow/src/types/fluereflow.rs#L63
warning: this function has too many arguments (27/7)
--> fluereflow/src/types/fluereflow.rs:63:5
|
63 | / pub fn new(
64 | | source: IpAddr,
65 | | destination: IpAddr,
66 | | d_pkts: u32,
... |
90 | | tos: u8,
91 | | ) -> FluereRecord {
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
|
|
returning the result of a `let` binding from a block:
fluere-config/src/init.rs#L75
warning: returning the result of a `let` binding from a block
--> fluere-config/src/init.rs:75:5
|
74 | let path_config = path_base.join("fluere");
| ------------------------------------------- unnecessary `let` binding
75 | path_config
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
= note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
|
74 ~
75 ~ path_base.join("fluere")
|
|