Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix git pull issue in download_plugin_from_github function #78

Closed
wants to merge 2 commits into from

Conversation

sweep-ai[bot]
Copy link
Contributor

@sweep-ai sweep-ai bot commented Nov 8, 2023

PR Feedback (click)

  • 👍 Sweep Did Well
  • 👎 Sweep Needs Improvement

Description

This PR addresses the issue where the git pull command in the download_plugin_from_github function was not working as expected. The function is designed to download a plugin from a GitHub repository and update it if it already exists. However, the git pull command was not updating the plugin as expected.

Summary of Changes

  • The git pull command has been replaced with git pull origin master to ensure that the command pulls from the master branch of the repository.
  • The git pull command is now executed in the directory of the cloned repository. Previously, the git pull command was being executed in the home cache directory, which may not have been the correct directory. The cd_cmd variable has been changed to let cd_cmd = format!("cd {}/{}", path.display(), repo_name.split('/').last().unwrap()); to reflect this change.
  • The function has been tested to ensure that it correctly pulls updates from the GitHub repository.

Fixes #69.


🎉 Latest improvements to Sweep:


💡 To get Sweep to edit this pull request, you can:

  • Comment below, and Sweep can edit the entire PR
  • Comment on a file, Sweep will only modify the commented file
  • Edit the original issue to get Sweep to recreate the PR from scratch

Copy link
Contributor Author

sweep-ai bot commented Nov 8, 2023

Sandbox Executions

Copy link
Contributor Author

sweep-ai bot commented Nov 8, 2023

Apply Sweep Rules to your PR?

@sweep-ai sweep-ai bot added the sweep Assigns Sweep to an issue or pull request. label Nov 8, 2023
Copy link

coderabbitai bot commented Nov 8, 2023

Important

Auto Review Skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.
  • @coderabbitai resolve to resolve all the CodeRabbit review comments.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@sweep-ai sweep-ai bot closed this Nov 8, 2023
@sweep-ai sweep-ai bot deleted the sweep/git-pull-issue branch November 8, 2023 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sweep Assigns Sweep to an issue or pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: git pull on downloaded plugin does not working
0 participants