-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
desktop/i3: Update version to 4.24 #8733
Conversation
reverse dependencies - desktop/i3
|
✅ sbolint - desktop/i3 ✅
|
@sbo-bot: build desktop/i3 |
buildpkg i586 desktop/i3
Snipped Build Failure
|
buildpkg x86_64 desktop/i3
Snipped Build Failure
|
@emman this failed to build |
Hi @willysr, I encountered an issue using slackrepo when compiling i3. The compilation fails if CHROOT=y, as the i3 tests require an active display to complete successfully. However, it compiles without issues when CHROOT=n. Do you have any recommendations on how to address this problem? thanks |
@aclemons is this can be solved by adding hint? |
Unfortunately not right now. Some things we just can't automate and have to manually check. I don't want to run the builds outside of a chroot (without the overlayfs) since I don't want trust running random scripts through the build server any more than we already do. The only other idea I have would be if we could have a flag for running the tests which defaults to "on", but we set them not to run for the build checks. |
@emman can you add those flags? |
it's quite strange as previous changes works just fine |
another way is to disable make test on perl section |
Could only now check on this. I tried this in an non-chroot env and it still fails. I also failed to build it with sbopkg. Looking closely at the output, it is not because of the chroot, but rather because the build server is headless.
Maybe instead of the flag we talked about above, maybe we could just check if DISPLAY is empty and skip the tests in that case? |
Hi, willy and aclemons, thanks for the feedback and help. |
@sbo-bot: build desktop/i3 |
buildpkg i586 desktop/i3
Snipped Build Log
|
sbopkglint i586 desktop/i3
|
buildpkg x86_64 desktop/i3
Snipped Build Log
|
sbopkglint x86_64 desktop/i3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
staged to my branch |
No description provided.