Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Forge maven URL and provide instructions on how to build #5535

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

embeddedt
Copy link

Without the Maven change, builds will fail because forgeSrc.jar is unavailable.

I've also added the EnderCore JAR to .gitignore so it doesn't show up as an untracked file.

@Pelotrio
Copy link

Pelotrio commented Oct 5, 2021

Can you actually build and run the game with this @embeddedt ? I had so many problems trying to do that with the current build gradle.

@embeddedt
Copy link
Author

embeddedt commented Oct 5, 2021

It did work at the time, but since then it seems to have broken again, as Player's Maven repository (http://maven.ic2.player.to) is now down. Do you know of any other Maven repos with Forestry and/or CoFHCore? Those are the two dependencies erroring for me.

@Pelotrio
Copy link

Pelotrio commented Oct 6, 2021

I encountered the same problem when I tried building forestry. After searching for a bit I just downloaded it and added it locally. Really annoying how hard it can be these days just to build a mod.

@embeddedt
Copy link
Author

Yes, and it definitely does not help that the community as a whole is becoming increasingly hostile to any pre-1.16 development.

You guys are doing great work with More Refined Storage. 🙂

@Pelotrio
Copy link

Pelotrio commented Oct 6, 2021

Thanks a lot it really is a nice project. Its also nice to see how many times I stumbled over your name just by looking at open prs and comments. I will see if I can build enderio with your changes tomorrow.

@embeddedt
Copy link
Author

The Forestry Maven repository came back. I tested this again and fixed one other Maven issue. It does build now without problems. runClient still has issues because of EnderCore being loaded twice.

This will likely be superseded by #5545 anyways.

@Pelotrio
Copy link

Pelotrio commented Oct 9, 2021

So you still cant run it? Is there anything that makes it work?

@embeddedt
Copy link
Author

You should be able to run the reobfuscated JAR produced by ./gradlew build. It's just userdev (./gradlew runClient) that doesn't work properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants