Merge pull request #172 from Sleitnick/bugfix/component-watch-handle

Fix trove mem leak
Sleitnick · Nov 1, 2023 · 2ee4399 · 2ee4399
2 parents a261ebd + 7114abc
commit 2ee4399
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/modules/component/init.lua b/modules/component/init.lua
@@ -169,10 +169,10 @@ type ComponentConfig = {
 local CollectionService = game:GetService("CollectionService")
 local RunService = game:GetService("RunService")
 
+local Promise = require(script.Parent.Promise)
 local Signal = require(script.Parent.Signal)
 local Symbol = require(script.Parent.Symbol)
 local Trove = require(script.Parent.Trove)
-local Promise = require(script.Parent.Promise)
 
 local IS_SERVER = RunService:IsServer()
 local DEFAULT_ANCESTORS = { workspace, game:GetService("Players") }
@@ -469,8 +469,8 @@ function Component:_setup()
 	local function InstanceUntagged(instance: Instance)
 		local watchHandle = watchingInstances[instance]
 		if watchHandle then
-			watchHandle:Disconnect()
 			watchingInstances[instance] = nil
+			self[KEY_TROVE]:Remove(watchHandle)
 		end
 		TryDeconstructComponent(instance)
 	end

diff --git a/modules/component/wally.toml b/modules/component/wally.toml
@@ -1,14 +1,14 @@
 [package]
 name = "sleitnick/component"
 description = "Component class"
-version = "2.4.6"
+version = "2.4.7"
 license = "MIT"
 authors = ["Stephen Leitnick"]
 registry = "https://github.com/UpliftGames/wally-index"
 realm = "shared"
 
 [dependencies]
-Signal = "sleitnick/signal@^1"
+Signal = "sleitnick/signal@^2"
 Symbol = "sleitnick/symbol@^2"
-Trove = "sleitnick/trove@^0.4"
+Trove = "sleitnick/trove@^1"
 Promise = "evaera/promise@^4"