Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File Save RPC #805

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

File Save RPC #805

wants to merge 4 commits into from

Conversation

ImUrX
Copy link
Member

@ImUrX ImUrX commented Aug 3, 2023

No description provided.

@ImUrX ImUrX added Area: Application Protocol Related to communication with apps like the GUI, overlay, games Type: Enhancement Adds or improves a feature labels Aug 3, 2023
@marcozzxx810
Copy link
Contributor

Do we have a issue for this PR?

(not related to this PR, but talking about this issue)

I think it will be great if we can save all the gui config.

Also thinking about pulling the config from a URL.

@ImUrX
Copy link
Member Author

ImUrX commented Sep 16, 2023

Do we have a issue for this PR?

nope, we dont.

I think it will be great if we can save all the gui config.

what for? I think it's fine for us to keep using localStorage

@ImUrX ImUrX linked an issue Jun 12, 2024 that may be closed by this pull request
Add a way to tell the server where to save a file #1055
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loucass003 loucass003 Awaiting requested review from loucass003 loucass003 will be requested when the pull request is marked ready for review loucass003 is a code owner

@ButterscotchV ButterscotchV Awaiting requested review from ButterscotchV ButterscotchV will be requested when the pull request is marked ready for review ButterscotchV is a code owner

@Erimelowo Erimelowo Awaiting requested review from Erimelowo Erimelowo will be requested when the pull request is marked ready for review Erimelowo is a code owner

@Eirenliel Eirenliel Awaiting requested review from Eirenliel Eirenliel will be requested when the pull request is marked ready for review Eirenliel is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Area: Application Protocol Related to communication with apps like the GUI, overlay, games Type: Enhancement Adds or improves a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a way to tell the server where to save a file
2 participants
@ImUrX @marcozzxx810