try removing kotlin warnings #941
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImUrX
added
Type: Enhancement
ImUrX
requested review from
ButterscotchV,
Eirenliel and
Erimelowo
as code owners
ButterscotchV
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
We cannot assume that humanPoseManager is not null, as it may be initialized before AutoBone in VRServer. It could technically be considered safe since I moved the initialization lower in VRServer, so it could be changed... Idk, I guess I won't block it over this, but technically it is not assured to be safe, I'd left it in before despite the warnings because of this reason.
There was a problem hiding this comment.
thats an interesting thing, what I'm curious about is that it's not a lateinit and kotlin is sure that it's not null, is something wrong in the parser maybe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw that there were a lot of kotlin warnings, so fixed some