Improve WiFi logging #358
Open
Improve WiFi logging #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESP8266 WiFi encryption type is according to 802.11, while ESP32 seems to report based on whatever... It would also be oh so convenient if we just report the name, so here it is
ButterscotchV
added
Type: Bug
ImUrX
reviewed
Nov 3, 2024
src/serial/serialcommands.cpp
Outdated
| @@ -248,9 +290,9 @@ namespace SerialCommands { | |||
| if (scanRes >= 0) { | |||
| logger.info("[WSCAN] Found %d networks:", scanRes); | |||
| for (int i = 0; i < scanRes; i++) { | |||
| logger.info("[WSCAN] %d:\t%02d\t%s\t(%d)\t%s", | |||
| logger.info("[WSCAN] %d: %02d '%s' (%d dBm) %s", | |||
There was a problem hiding this comment.
the original reason for the usages of \t and no ' or is because it simplified parsing as the only people that would be able to input tab in their SSID would be people that know what the hell they are doing, a ' or a could easily be put on the SSID and break parsing
There was a problem hiding this comment.
Switched to tabs now, the ' can be considered to always surround the SSID and be trimmed (and/or use the length printed before)
It was mentioned this would be easier for parsing, so I'll just leave it the same but with quotes, as it's still just as readable now
|
Tested on official trackers and it works :3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently our WiFi stuff is logged in different ways each time we log it, this makes it all surround the SSID in singlequotes and the "OPEN" vs "PASSWD" printout now just says the encryption type (plus it never worked on ESP8266 since "OPEN" is actually 7, not 0).
I'm absolutely certain this isn't the best way of doing this so please complain about it in the reviews/comments or whatever and I can fix it.