Merge pull request #971 from SlovakNationalGallery/fix-empty-authors

Filter out empty values from getUniqueAuthorsWithAuthorityNames
SlovakNationalGallery · Mar 14, 2024 · fafb99f · fafb99f
2 parents aeb61c4 + 17539e6
commit fafb99f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/app/Item.php b/app/Item.php
@@ -396,12 +396,12 @@ public function getAuthorsWithAuthoritiesAttribute()
         return $authorities->concat($authors);
     }
 
-
     public function getUniqueAuthorsWithAuthorityNames()
     {
         return $this->authors_with_authorities
             ->pluck('name')
-            ->toArray();
+            ->filter()
+            ->values();
     }
 
     public function getFirstAuthorAttribute($value)

diff --git a/tests/Models/ItemTest.php b/tests/Models/ItemTest.php
@@ -147,7 +147,7 @@ public function testMergedAuthorityNamesAndAuthors()
         ]);
 
         $item = Item::factory()->make([
-            'author' => 'Philips Wouwerman; Vladimír Boudník',
+            'author' => 'Philips Wouwerman; ; Vladimír Boudník',
         ]);
         $item->authorities()->attach($authority);