Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-write sorting selector using radix-vue #1003

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Re-write sorting selector using radix-vue #1003

merged 2 commits into from
Apr 26, 2024

Conversation

eronisko
Copy link
Contributor

and remove unused Popover code.

Fixes # (link to Jira or GitHub issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have updated the CHANGELOG
  • I have requested at least 1 reviewer for this PR
  • I have made corresponding changes to the documentation

@eronisko eronisko force-pushed the new-sort-selector branch from 5a22e29 to 28cfbe8 Compare April 25, 2024 08:57
Base automatically changed from new-catalog-various to main April 25, 2024 10:25
@eronisko eronisko force-pushed the new-sort-selector branch from 28cfbe8 to 392b588 Compare April 25, 2024 10:27
FrantisekMichalSebestyen
FrantisekMichalSebestyen requested changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@FrantisekMichalSebestyen FrantisekMichalSebestyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just fix the hiding of selector on resize

@eronisko eronisko merged commit 540e740 into main Apr 26, 2024
1 check passed
@eronisko eronisko deleted the new-sort-selector branch April 26, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrantisekMichalSebestyen FrantisekMichalSebestyen FrantisekMichalSebestyen approved these changes

@igor-kamil igor-kamil Awaiting requested review from igor-kamil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eronisko @FrantisekMichalSebestyen