Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-order filters #1004

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Re-order filters #1004

merged 3 commits into from
Apr 26, 2024

Conversation

eronisko
Copy link
Contributor

  • re-order filters
  • fix total count presentation
  • change label "tag" -> "keyword"

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have updated the CHANGELOG
  • I have requested at least 1 reviewer for this PR
  • I have made corresponding changes to the documentation

Base automatically changed from new-sort-selector to main April 26, 2024 08:36
@eronisko eronisko force-pushed the WEBUMENIA-2076-filters-order branch from d81e9c0 to 6f14ad8 Compare April 26, 2024 08:41
FrantisekMichalSebestyen
FrantisekMichalSebestyen approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@FrantisekMichalSebestyen FrantisekMichalSebestyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eronisko eronisko merged commit 72ae2da into main Apr 26, 2024
1 check passed
@eronisko eronisko deleted the WEBUMENIA-2076-filters-order branch April 26, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrantisekMichalSebestyen FrantisekMichalSebestyen FrantisekMichalSebestyen approved these changes

@igor-kamil igor-kamil Awaiting requested review from igor-kamil

@ustengrav ustengrav Awaiting requested review from ustengrav

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eronisko @FrantisekMichalSebestyen