Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[item] allow viewing of all items in api v2 #1017

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Conversation

rastislav-chynoransky
Copy link
Contributor

Copy link
Member

@igor-kamil igor-kamil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. just a tiny note. not necessary to implement. can be merged as it is.

Comment on lines -22 to -24
if (!$ids || !is_array($ids)) {
return response()->json(['error' => 'Invalid input'], 400);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just saying - I would like to keep validation whether ids is array. it doesn't have to be required.

Copy link
Member

@igor-kamil igor-kamil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice! 👌

@rastislav-chynoransky rastislav-chynoransky merged commit c7c39a9 into main Jun 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants