Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change /api/v1/items/aggregations filtering logic #879

Merged
merged 7 commits into from
Aug 24, 2023
Merged

Change /api/v1/items/aggregations filtering logic #879

merged 7 commits into from
Aug 24, 2023

Conversation

eronisko
Copy link
Contributor

  • added tests
  • facet now does not affect itself (but just other facets)
  • filtered (i.e. selected) value are always included in the aggregation results, so that they don't disappear

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have updated the CHANGELOG
  • I have requested at least 1 reviewer for this PR
  • I have made corresponding changes to the documentation

@eronisko
Copy link
Contributor Author

@FrantisekMichalSebestyen I've added the exception for date_earliest/date_latest

@eronisko eronisko merged commit 5894192 into develop Aug 24, 2023
1 check passed
@eronisko eronisko deleted the WEBUMENIA-1987-zmenit-logiku-agregacii-pri-kombinaciach-filtrov branch August 24, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igor-kamil igor-kamil Awaiting requested review from igor-kamil

@rastislav-chynoransky rastislav-chynoransky Awaiting requested review from rastislav-chynoransky

@FrantisekMichalSebestyen FrantisekMichalSebestyen Awaiting requested review from FrantisekMichalSebestyen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eronisko @FrantisekMichalSebestyen