cursor: Rename set_callback() to set_fallback() to match intent
#723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intent of this function is to set a _fallback_ that `get_cursor()` uses when no cursor can be loaded. This fallback _is_ a _callback_ (or _closure_ / `Fn` in Rust terms) that calculates an optional fallback value based on the given name and size of the requested cursor. Also make sure this "fallback" setter is properly linked from `get_cursor()`, making it easier to find when users attempt to understand the docs.
MarijnS95
force-pushed
the
cursor-set-fallback
branch
from
f2d5207
to
15d81d7
Compare
|
LGTM, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @Decodetalkers based on discussions in #680 (comment).
The intent of this function is to set a fallback that
get_cursor()uses when no cursor can be loaded. This fallback is a callback (or closure /Fnin Rust terms) that calculates an optional fallback value based on the given name and size of the requested cursor.Also make sure this "fallback" setter is properly linked from
get_cursor(), making it easier to find when users attempt to understand the docs.