Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend: Add destroy_object method #727

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ids1024
Copy link
Member

@ids1024 ids1024 commented May 15, 2024

This is needed for implementing the wl_fixes protocol. It should also make it possible to handle the requirement in zwlr_output_configuration_v1::destroy to destroy the wlr_output_configuration_head.

Split off from #726. See Smithay/smithay#1428 and rust-windowing/softbuffer#218 for server-side and client-side uses of this.

Copy link
Member

@elinorbgr elinorbgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the high-level principle LGTM, but see my comments for the implementation.

Also, I think we should add some tests to the wayland-backend test module to cover these API. I'm thinking at least the two cases : trying to destroy the same object twice, and trying to send a message through an object after it has already been manually destroyed.

wayland-backend/src/rs/server_impl/client.rs Show resolved Hide resolved
wayland-backend/src/sys/client_impl/mod.rs Show resolved Hide resolved
wayland-backend/src/sys/server_impl/mod.rs Outdated Show resolved Hide resolved
This is needed for implementing the `wl_fixes` protocol. It should also
make it possible to handle the requirement in
`zwlr_output_configuration_v1::destroy` to destroy the
`wlr_output_configuration_head`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants