Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orbital elements based calculations #96

Merged
merged 7 commits into from
Nov 15, 2024
Merged

Orbital elements based calculations #96

merged 7 commits into from
Nov 15, 2024

Conversation

attipaci
Copy link
Collaborator

@attipaci attipaci commented Nov 13, 2024

Added

  • NOVAS_ORBITAL_OBJECT to enum novas_planet.
  • novas_orbital_elements structure, including novas_orbital_system substructure, and enum novas_reference_plane to distiguish ecliptic vs equatorial orbital parameters, and novas_set_orbital_pole() helper function to configure.
  • object.orbit field containing novas_orbital_elements data
  • novas_orbit_posvel() function to calculate position and velocity vectors from orbital elements.
  • make_orbital_object() function to ease the creation of objects with orbital parameters.

Changed

  • ephemeris() call to process NOVAS_ORBITAL_OBJECT types via novas_orbit_posvel().

@attipaci attipaci added the enhancement New feature or request label Nov 13, 2024
@attipaci attipaci added this to the 1.2.0 milestone Nov 13, 2024
@attipaci attipaci self-assigned this Nov 13, 2024
@attipaci attipaci linked an issue Nov 13, 2024 that may be closed by this pull request
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.70%. Comparing base (1e3d54e) to head (15911b9).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
+ Coverage   99.65%   99.70%   +0.04%     
==========================================
  Files           8        8              
  Lines        2914     3024     +110     
  Branches      561      575      +14     
==========================================
+ Hits         2904     3015     +111     
+ Partials       10        9       -1     
Flag Coverage Δ
unittests 99.70% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/frames.c 99.52% <ø> (ø)
src/novas.c 99.62% <100.00%> (+0.07%) ⬆️
src/super.c 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e3d54e...15911b9. Read the comment docs.

@attipaci attipaci force-pushed the orbital-elements branch 13 times, most recently from 87afc50 to c89e624 Compare November 14, 2024 10:44
@attipaci attipaci force-pushed the orbital-elements branch 3 times, most recently from 6b2ac27 to e34b056 Compare November 14, 2024 12:44
@attipaci attipaci changed the title Orbital element based calculations Orbital elements based calculations Nov 14, 2024
src/novas.c Fixed Show fixed Hide fixed
@attipaci attipaci force-pushed the orbital-elements branch 4 times, most recently from 027fbd6 to 70c911f Compare November 15, 2024 12:29
@attipaci attipaci marked this pull request as ready for review November 15, 2024 12:33
@attipaci attipaci merged commit b321692 into main Nov 15, 2024
16 checks passed
@attipaci attipaci deleted the orbital-elements branch November 15, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add orbital elements processing
1 participant