Fixing some compile issues for alpine and centos, also fix endian issue for FLASH hashslot prefix #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnSully
requested changes
Oct 6, 2023
src/storage/rocksdb.cpp
Outdated
| @@ -25,7 +27,7 @@ bool FInternalKey(const char *key, size_t cch) | |||
| std::string getPrefix(unsigned int hashslot) | |||
| { | |||
| char *hash_char = (char *)&hashslot; | |||
| return std::string(hash_char + (sizeof(unsigned int) - 2), 2); | |||
| return std::string(hash_char, sizeof(unsigned int)); | |||
There was a problem hiding this comment.
You want uint16_t not unsigned, otherwise your wasting 2 bytes for every key
JohnSully
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation of hash slot prefix resulted in incorrect enumeration due to using the wrong 2 bytes, so just use the whole value.
Fixes issue #677.
also update alpine version in Dockerfile Fixes issue #721.