Add helm chart #19

s-vitaliy · 2024-04-08T14:35:51Z

Part of #8

Scope

Implemented:

Add Helm chart for Arcane deployments

Additional changes:

Refactored appsettings.json: remove obsolete values
Remove Parallelism settings from configuration.

Checklist

GitHub issue exists for this change.
Unit tests added and they pass.
Line Coverage is at least 80%.
Review requested on latest commit.

github-actions · 2024-04-08T14:37:05Z

Coverage after merging add-helm-chart into main will be

44.25%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
ArcaneEnvironment.cs	0%	100%	0%	0%	10, 5, 8–9
src/Extensions
V1JobExtensions.cs	85.58%	75%	90.91%	90.16%	40, 40, 45, 61–62, 62, 62, 62, 62–65, 83, 83
src/Models/StreamClass
V1Beta1StreamClassSpec.cs	0%	100%	0%	0%	11, 17, 23, 30
src/Models/StreamDefinitions/Base
IStreamDefinition.cs	90%	83.33%	100%	100%	28
src/Models/StreamStatuses/StreamStatus/V1Beta1
V1Beta1StreamStatus.cs	100%	100%	100%	100%
src/Services
StreamInteractionService.cs	0%	100%	0%	0%	16–19, 23–27, 31–35, 39–45
src/Services/Maintenance
HostedStreamingJobMaintenanceService.cs	0%	0%	0%	0%	16–24, 27–29, 29, 29–36, 39–42
StreamingJobMaintenanceService.cs	89.84%	82.14%	100%	91.40%	104–107, 122, 131–134, 136, 62, 67, 98
src/Services/Operator
BackgroundStreamOperatorService.cs	0%	0%	0%	0%	22–31, 38–41, 47–51, 54–56, 56, 56–64
HostedStreamOperatorService.cs	82.14%	100%	66.67%	82.61%	39–42
StreamOperatorService.cs	93.47%	87.04%	100%	95.65%	107–113, 118, 126, 140, 140, 146, 168
StreamOperatorServiceFactory.cs	0%	100%	0%	0%	22–32, 36–50
src/Services/Repositories
StreamDefinitionRepository.cs	0%	0%	0%	0%	100, 100, 100, 100, 100, 100, 100, 100, 100–103, 106–113, 23–30, 33–35, 35, 35, 35, 35, 35, 35, 35, 35–38, 41–50, 54–62, 62, 62, 62, 62, 62, 62, 62, 62–65, 68–77, 80–82, 82, 82, 82, 82, 82, 82, 82, 82–85, 88–95, 98–99
StreamingJobTemplateRepository.cs	0%	0%	0%	0%	18–25, 29–31, 31, 31, 31, 31, 31, 31, 31, 31–36, 39–47
src/Services/Streams
StreamingJobOperatorService.cs	0%	0%	0%	0%	100–107, 110–113, 113, 113–115, 118–121, 121, 121–123, 126–129, 129, 129–131, 134–137, 140–146, 150–152, 152, 152, 152, 152–155, 155, 155, 155, 155–156, 158–161, 163–169, 173, 173, 173, 173, 173–179, 182–188, 191–200, 31–43, 46, 49–56, 59–60, 60, 60–63, 63, 63–70, 70, 70–90, 90, 90, 90, 90–93, 93, 93–99

github-actions · 2024-04-08T14:37:16Z

Coverage after merging add-helm-chart into main will be

44.25%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
ArcaneEnvironment.cs	0%	100%	0%	0%	10, 5, 8–9
src/Extensions
V1JobExtensions.cs	85.58%	75%	90.91%	90.16%	40, 40, 45, 61–62, 62, 62, 62, 62–65, 83, 83
src/Models/StreamClass
V1Beta1StreamClassSpec.cs	0%	100%	0%	0%	11, 17, 23, 30
src/Models/StreamDefinitions/Base
IStreamDefinition.cs	90%	83.33%	100%	100%	28
src/Models/StreamStatuses/StreamStatus/V1Beta1
V1Beta1StreamStatus.cs	100%	100%	100%	100%
src/Services
StreamInteractionService.cs	0%	100%	0%	0%	16–19, 23–27, 31–35, 39–45
src/Services/Maintenance
HostedStreamingJobMaintenanceService.cs	0%	0%	0%	0%	16–24, 27–29, 29, 29–36, 39–42
StreamingJobMaintenanceService.cs	89.84%	82.14%	100%	91.40%	104–107, 122, 131–134, 136, 62, 67, 98
src/Services/Operator
BackgroundStreamOperatorService.cs	0%	0%	0%	0%	22–31, 38–41, 47–51, 54–56, 56, 56–64
HostedStreamOperatorService.cs	82.14%	100%	66.67%	82.61%	39–42
StreamOperatorService.cs	93.47%	87.04%	100%	95.65%	107–113, 118, 126, 140, 140, 146, 168
StreamOperatorServiceFactory.cs	0%	100%	0%	0%	22–32, 36–50
src/Services/Repositories
StreamDefinitionRepository.cs	0%	0%	0%	0%	100, 100, 100, 100, 100, 100, 100, 100, 100–103, 106–113, 23–30, 33–35, 35, 35, 35, 35, 35, 35, 35, 35–38, 41–50, 54–62, 62, 62, 62, 62, 62, 62, 62, 62–65, 68–77, 80–82, 82, 82, 82, 82, 82, 82, 82, 82–85, 88–95, 98–99
StreamingJobTemplateRepository.cs	0%	0%	0%	0%	18–25, 29–31, 31, 31, 31, 31, 31, 31, 31, 31–36, 39–47
src/Services/Streams
StreamingJobOperatorService.cs	0%	0%	0%	0%	100–107, 110–113, 113, 113–115, 118–121, 121, 121–123, 126–129, 129, 129–131, 134–137, 140–146, 150–152, 152, 152, 152, 152–155, 155, 155, 155, 155–156, 158–161, 163–169, 173, 173, 173, 173, 173–179, 182–188, 191–200, 31–43, 46, 49–56, 59–60, 60, 60–63, 63, 63–70, 70, 70–90, 90, 90, 90, 90–93, 93, 93–99

github-actions · 2024-04-08T14:46:23Z

Coverage after merging add-helm-chart into main will be

44.25%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
ArcaneEnvironment.cs	0%	100%	0%	0%	10, 5, 8–9
src/Extensions
V1JobExtensions.cs	85.58%	75%	90.91%	90.16%	40, 40, 45, 61–62, 62, 62, 62, 62–65, 83, 83
src/Models/StreamClass
V1Beta1StreamClassSpec.cs	0%	100%	0%	0%	11, 17, 23, 30
src/Models/StreamDefinitions/Base
IStreamDefinition.cs	90%	83.33%	100%	100%	28
src/Models/StreamStatuses/StreamStatus/V1Beta1
V1Beta1StreamStatus.cs	100%	100%	100%	100%
src/Services
StreamInteractionService.cs	0%	100%	0%	0%	16–19, 23–27, 31–35, 39–45
src/Services/Maintenance
HostedStreamingJobMaintenanceService.cs	0%	0%	0%	0%	16–24, 27–29, 29, 29–36, 39–42
StreamingJobMaintenanceService.cs	89.84%	82.14%	100%	91.40%	104–107, 122, 131–134, 136, 62, 67, 98
src/Services/Operator
BackgroundStreamOperatorService.cs	0%	0%	0%	0%	22–31, 38–41, 47–51, 54–56, 56, 56–64
HostedStreamOperatorService.cs	82.14%	100%	66.67%	82.61%	39–42
StreamOperatorService.cs	93.47%	87.04%	100%	95.65%	107–113, 118, 126, 140, 140, 146, 168
StreamOperatorServiceFactory.cs	0%	100%	0%	0%	22–32, 36–50
src/Services/Repositories
StreamDefinitionRepository.cs	0%	0%	0%	0%	100, 100, 100, 100, 100, 100, 100, 100, 100–103, 106–113, 23–30, 33–35, 35, 35, 35, 35, 35, 35, 35, 35–38, 41–50, 54–62, 62, 62, 62, 62, 62, 62, 62, 62–65, 68–77, 80–82, 82, 82, 82, 82, 82, 82, 82, 82–85, 88–95, 98–99
StreamingJobTemplateRepository.cs	0%	0%	0%	0%	18–25, 29–31, 31, 31, 31, 31, 31, 31, 31, 31–36, 39–47
src/Services/Streams
StreamingJobOperatorService.cs	0%	0%	0%	0%	100–107, 110–113, 113, 113–115, 118–121, 121, 121–123, 126–129, 129, 129–131, 134–137, 140–146, 150–152, 152, 152, 152, 152–155, 155, 155, 155, 155–156, 158–161, 163–169, 173, 173, 173, 173, 173–179, 182–188, 191–200, 31–43, 46, 49–56, 59–60, 60, 60–63, 63, 63–70, 70, 70–90, 90, 90, 90, 90–93, 93, 93–99

github-actions · 2024-04-08T14:46:32Z

Coverage after merging add-helm-chart into main will be

44.25%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
ArcaneEnvironment.cs	0%	100%	0%	0%	10, 5, 8–9
src/Extensions
V1JobExtensions.cs	85.58%	75%	90.91%	90.16%	40, 40, 45, 61–62, 62, 62, 62, 62–65, 83, 83
src/Models/StreamClass
V1Beta1StreamClassSpec.cs	0%	100%	0%	0%	11, 17, 23, 30
src/Models/StreamDefinitions/Base
IStreamDefinition.cs	90%	83.33%	100%	100%	28
src/Models/StreamStatuses/StreamStatus/V1Beta1
V1Beta1StreamStatus.cs	100%	100%	100%	100%
src/Services
StreamInteractionService.cs	0%	100%	0%	0%	16–19, 23–27, 31–35, 39–45
src/Services/Maintenance
HostedStreamingJobMaintenanceService.cs	0%	0%	0%	0%	16–24, 27–29, 29, 29–36, 39–42
StreamingJobMaintenanceService.cs	89.84%	82.14%	100%	91.40%	104–107, 122, 131–134, 136, 62, 67, 98
src/Services/Operator
BackgroundStreamOperatorService.cs	0%	0%	0%	0%	22–31, 38–41, 47–51, 54–56, 56, 56–64
HostedStreamOperatorService.cs	82.14%	100%	66.67%	82.61%	39–42
StreamOperatorService.cs	93.47%	87.04%	100%	95.65%	107–113, 118, 126, 140, 140, 146, 168
StreamOperatorServiceFactory.cs	0%	100%	0%	0%	22–32, 36–50
src/Services/Repositories
StreamDefinitionRepository.cs	0%	0%	0%	0%	100, 100, 100, 100, 100, 100, 100, 100, 100–103, 106–113, 23–30, 33–35, 35, 35, 35, 35, 35, 35, 35, 35–38, 41–50, 54–62, 62, 62, 62, 62, 62, 62, 62, 62–65, 68–77, 80–82, 82, 82, 82, 82, 82, 82, 82, 82–85, 88–95, 98–99
StreamingJobTemplateRepository.cs	0%	0%	0%	0%	18–25, 29–31, 31, 31, 31, 31, 31, 31, 31, 31–36, 39–47
src/Services/Streams
StreamingJobOperatorService.cs	0%	0%	0%	0%	100–107, 110–113, 113, 113–115, 118–121, 121, 121–123, 126–129, 129, 129–131, 134–137, 140–146, 150–152, 152, 152, 152, 152–155, 155, 155, 155, 155–156, 158–161, 163–169, 173, 173, 173, 173, 173–179, 182–188, 191–200, 31–43, 46, 49–56, 59–60, 60, 60–63, 63, 63–70, 70, 70–90, 90, 90, 90, 90–93, 93, 93–99

george-zubrienko

Let's discuss values file design a bit. Also I think a values.example.yaml would be great

george-zubrienko · 2024-04-09T07:30:28Z

.helm/templates/crd-job-template.yaml

+metadata:
+  name: streaming-job-templates.streaming.sneaksanddata.com
+spec:
+  group: streaming.sneaksanddata.com


I'm curious if we should use our domain here. I'll ask Jakob

george-zubrienko · 2024-04-09T07:31:02Z

.helm/templates/crd-streamclass.yaml

+    shortNames:
+      - streamclass
+      - streamcls
+      - sc


Yes, would be better.

george-zubrienko · 2024-04-09T07:31:25Z

.helm/templates/crd-streamclass.yaml

+                    - INITIALIZING
+                    - READY
+                    - FAILED
+                    - STOPPED


Indent seems off?

No, the indentation is correct.

george-zubrienko · 2024-04-09T07:31:57Z

.helm/templates/deployment.yaml

+  selector:
+    matchLabels:
+      {{- include "app.selectorLabels" $ | nindent 6 }}
+  # For now Arcane Operator supports only single replica


What's the todo here? Leader election?

Yes, we can implement failover using Kubernetes leases: https://kubernetes.io/docs/concepts/architecture/leases/#custom-workload

george-zubrienko · 2024-04-09T07:33:55Z

.helm/values.yaml

+# Fullname override
+fullnameOverride: ""
+
+# Service account configuration
 serviceAccount:


Indent off here?

No, the indentation is correct.

george-zubrienko · 2024-04-09T07:34:30Z

.helm/values.yaml

  # The name of the service account to use.
  # If not set and create is true, a name is generated using the fullname template
  name: ""
+
+# Additional labels for the deployment and pods
+additionalLabels: {}


Let's do operator.labels, maintainer.labels?

The Operator and Maintainer work in the same process.

george-zubrienko · 2024-04-09T07:34:40Z

.helm/values.yaml

+additionalLabels: {}
+
+# Additional labels for the deployment and pods
+additionalAnnotations: {}


Same here :)

george-zubrienko · 2024-04-09T07:34:57Z

.helm/values.yaml

+additionalAnnotations: {}
+
+# Extra environment variables to set in the deployment
+extraEnv: {}


Same here :)

github-actions · 2024-04-09T08:36:13Z

Coverage after merging add-helm-chart into main will be

44.25%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
ArcaneEnvironment.cs	0%	100%	0%	0%	10, 5, 8–9
src/Extensions
V1JobExtensions.cs	85.58%	75%	90.91%	90.16%	40, 40, 45, 61–62, 62, 62, 62, 62–65, 83, 83
src/Models/StreamClass
V1Beta1StreamClassSpec.cs	0%	100%	0%	0%	11, 17, 23, 30
src/Models/StreamDefinitions/Base
IStreamDefinition.cs	90%	83.33%	100%	100%	28
src/Models/StreamStatuses/StreamStatus/V1Beta1
V1Beta1StreamStatus.cs	100%	100%	100%	100%
src/Services
StreamInteractionService.cs	0%	100%	0%	0%	16–19, 23–27, 31–35, 39–45
src/Services/Maintenance
HostedStreamingJobMaintenanceService.cs	0%	0%	0%	0%	16–24, 27–29, 29, 29–36, 39–42
StreamingJobMaintenanceService.cs	89.84%	82.14%	100%	91.40%	104–107, 122, 131–134, 136, 62, 67, 98
src/Services/Operator
BackgroundStreamOperatorService.cs	0%	0%	0%	0%	22–31, 38–41, 47–51, 54–56, 56, 56–64
HostedStreamOperatorService.cs	82.14%	100%	66.67%	82.61%	39–42
StreamOperatorService.cs	93.47%	87.04%	100%	95.65%	107–113, 118, 126, 140, 140, 146, 168
StreamOperatorServiceFactory.cs	0%	100%	0%	0%	22–32, 36–50
src/Services/Repositories
StreamDefinitionRepository.cs	0%	0%	0%	0%	100, 100, 100, 100, 100, 100, 100, 100, 100–103, 106–113, 23–30, 33–35, 35, 35, 35, 35, 35, 35, 35, 35–38, 41–50, 54–62, 62, 62, 62, 62, 62, 62, 62, 62–65, 68–77, 80–82, 82, 82, 82, 82, 82, 82, 82, 82–85, 88–95, 98–99
StreamingJobTemplateRepository.cs	0%	0%	0%	0%	18–25, 29–31, 31, 31, 31, 31, 31, 31, 31, 31–36, 39–47
src/Services/Streams
StreamingJobOperatorService.cs	0%	0%	0%	0%	100–107, 110–113, 113, 113–115, 118–121, 121, 121–123, 126–129, 129, 129–131, 134–137, 140–146, 150–152, 152, 152, 152, 152–155, 155, 155, 155, 155–156, 158–161, 163–169, 173, 173, 173, 173, 173–179, 182–188, 191–200, 31–43, 46, 49–56, 59–60, 60, 60–63, 63, 63–70, 70, 70–90, 90, 90, 90, 90–93, 93, 93–99

github-actions · 2024-04-09T09:01:31Z

Coverage after merging add-helm-chart into main will be

54.26%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
ArcaneEnvironment.cs	0%	100%	0%	0%	10, 5, 8–9
src/Extensions
V1JobExtensions.cs	85.58%	75%	90.91%	90.16%	40, 40, 45, 61–62, 62, 62, 62, 62–65, 83, 83
src/Models/StreamClass
V1Beta1StreamClassSpec.cs	25%	100%	25%	25%	11, 17, 23
src/Models/StreamDefinitions/Base
IStreamDefinition.cs	90%	83.33%	100%	100%	28
src/Models/StreamStatuses/StreamStatus/V1Beta1
V1Beta1StreamStatus.cs	100%	100%	100%	100%
src/Services
StreamInteractionService.cs	0%	100%	0%	0%	16–19, 23–27, 31–35, 39–45
src/Services/Maintenance
HostedStreamingJobMaintenanceService.cs	0%	0%	0%	0%	16–24, 27–29, 29, 29–36, 39–42
StreamingJobMaintenanceService.cs	89.84%	82.14%	100%	91.40%	104–107, 122, 131–134, 136, 62, 67, 98
src/Services/Operator
HostedStreamOperatorService.cs	82.14%	100%	66.67%	82.61%	39–42
StreamClassOperatorService.cs	70.30%	40%	75%	73.49%	107–110, 116, 121–122, 127–130, 74, 74, 77, 79, 84–86, 86, 86–91, 97–99
StreamOperatorService.cs	93.47%	87.04%	100%	95.65%	107–113, 118, 126, 140, 140, 146, 168
StreamOperatorServiceWorker.cs	77.78%	50%	75%	80%	47–51, 56, 64
StreamOperatorServiceWorkerFactory.cs	100%	100%	100%	100%
src/Services/Repositories
StreamDefinitionRepository.cs	0%	0%	0%	0%	100, 100, 100, 100, 100, 100, 100, 100, 100–103, 106–113, 23–30, 33–35, 35, 35, 35, 35, 35, 35, 35, 35–38, 41–50, 54–62, 62, 62, 62, 62, 62, 62, 62, 62–65, 68–77, 80–82, 82, 82, 82, 82, 82, 82, 82, 82–85, 88–95, 98–99
StreamingJobTemplateRepository.cs	0%	0%	0%	0%	18–25, 29–31, 31, 31, 31, 31, 31, 31, 31, 31–36, 39–47
src/Services/Streams
StreamingJobOperatorService.cs	0%	0%	0%	0%	100–107, 110–113, 113, 113–115, 118–121, 121, 121–123, 126–129, 129, 129–131, 134–137, 140–146, 150–152, 152, 152, 152, 152–155, 155, 155, 155, 155–156, 158–161, 163–169, 173, 173, 173, 173, 173–179, 182–188, 191–200, 31–43, 46, 49–56, 59–60, 60, 60–63, 63, 63–70, 70, 70–90, 90, 90, 90, 90–93, 93, 93–99

github-actions · 2024-04-09T15:29:07Z

Coverage after merging add-helm-chart into main will be

53.33%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
ArcaneEnvironment.cs	0%	100%	0%	0%	10, 5, 8–9
src/Extensions
JsonElementExtensions.cs	0%	100%	0%	0%	20
V1JobExtensions.cs	85.58%	75%	90.91%	90.16%	40, 40, 45, 61–62, 62, 62, 62, 62–65, 83, 83
src/Models/StreamClass
V1Beta1StreamClassSpec.cs	20%	100%	20%	20%	11, 17, 23, 29
src/Models/StreamClass/Base
IStreamClass.cs	0%	100%	0%	0%	44–49
src/Models/StreamDefinitions/Base
IStreamDefinition.cs	90%	83.33%	100%	100%	28
src/Models/StreamStatuses/StreamStatus/V1Beta1
V1Beta1StreamStatus.cs	100%	100%	100%	100%
src/Services
StreamInteractionService.cs	0%	100%	0%	0%	16–19, 23–27, 31–35, 39–45
src/Services/Maintenance
HostedStreamingJobMaintenanceService.cs	0%	0%	0%	0%	16–24, 27–29, 29, 29–36, 39–42
StreamingJobMaintenanceService.cs	89.84%	82.14%	100%	91.40%	104–107, 122, 131–134, 136, 62, 67, 98
src/Services/Operator
HostedStreamOperatorService.cs	82.14%	100%	66.67%	82.61%	39–42
StreamClassOperatorService.cs	70.30%	40%	75%	73.49%	107–110, 116, 121–122, 127–130, 74, 74, 77, 79, 84–86, 86, 86–91, 97–99
StreamOperatorService.cs	93.47%	87.04%	100%	95.65%	107–113, 118, 126, 140, 140, 146, 168
StreamOperatorServiceWorker.cs	77.78%	50%	75%	80%	47–51, 56, 64
StreamOperatorServiceWorkerFactory.cs	100%	100%	100%	100%
src/Services/Repositories
StreamDefinitionRepository.cs	0%	0%	0%	0%	100–111, 22–29, 32–34, 34, 34–49, 53–55, 55, 55–76, 79–81, 81, 81–93, 96–98, 98, 98–99
StreamingJobTemplateRepository.cs	0%	0%	0%	0%	20–27, 31–33, 33, 33, 33, 33, 33, 33, 33, 33–36, 39–47
src/Services/Streams
StreamingJobOperatorService.cs	0%	0%	0%	0%	100–107, 110–113, 113, 113–115, 118–121, 121, 121–123, 126–129, 129, 129–131, 134–137, 140–146, 150–152, 152, 152, 152, 152–155, 155, 155, 155, 155–156, 158–161, 163–169, 173, 173, 173, 173, 173–179, 182–188, 191–200, 31–43, 46, 49–56, 59–60, 60, 60–63, 63, 63–70, 70, 70–90, 90, 90, 90, 90–93, 93, 93–99

github-actions · 2024-04-10T08:01:18Z

Coverage after merging add-helm-chart into main will be

53.33%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
ArcaneEnvironment.cs	0%	100%	0%	0%	10, 5, 8–9
src/Extensions
JsonElementExtensions.cs	0%	100%	0%	0%	20
V1JobExtensions.cs	85.58%	75%	90.91%	90.16%	40, 40, 45, 61–62, 62, 62, 62, 62–65, 83, 83
src/Models/StreamClass
V1Beta1StreamClassSpec.cs	20%	100%	20%	20%	11, 17, 23, 29
src/Models/StreamClass/Base
IStreamClass.cs	0%	100%	0%	0%	44–49
src/Models/StreamDefinitions/Base
IStreamDefinition.cs	90%	83.33%	100%	100%	28
src/Models/StreamStatuses/StreamStatus/V1Beta1
V1Beta1StreamStatus.cs	100%	100%	100%	100%
src/Services
StreamInteractionService.cs	0%	100%	0%	0%	16–19, 23–27, 31–35, 39–45
src/Services/Maintenance
HostedStreamingJobMaintenanceService.cs	0%	0%	0%	0%	16–24, 27–29, 29, 29–36, 39–42
StreamingJobMaintenanceService.cs	89.84%	82.14%	100%	91.40%	104–107, 122, 131–134, 136, 62, 67, 98
src/Services/Operator
HostedStreamOperatorService.cs	82.14%	100%	66.67%	82.61%	39–42
StreamClassOperatorService.cs	70.30%	40%	75%	73.49%	107–110, 116, 121–122, 127–130, 74, 74, 77, 79, 84–86, 86, 86–91, 97–99
StreamOperatorService.cs	93.47%	87.04%	100%	95.65%	107–113, 118, 126, 140, 140, 146, 168
StreamOperatorServiceWorker.cs	77.78%	50%	75%	80%	47–51, 56, 64
StreamOperatorServiceWorkerFactory.cs	100%	100%	100%	100%
src/Services/Repositories
StreamDefinitionRepository.cs	0%	0%	0%	0%	100–111, 22–29, 32–34, 34, 34–49, 53–55, 55, 55–76, 79–81, 81, 81–93, 96–98, 98, 98–99
StreamingJobTemplateRepository.cs	0%	0%	0%	0%	20–27, 31–33, 33, 33, 33, 33, 33, 33, 33, 33–36, 39–47
src/Services/Streams
StreamingJobOperatorService.cs	0%	0%	0%	0%	100–107, 110–113, 113, 113–115, 118–121, 121, 121–123, 126–129, 129, 129–131, 134–137, 140–146, 150–152, 152, 152, 152, 152–155, 155, 155, 155, 155–156, 158–161, 163–169, 173, 173, 173, 173, 173–179, 182–188, 191–200, 31–43, 46, 49–56, 59–60, 60, 60–63, 63, 63–70, 70, 70–90, 90, 90, 90, 90–93, 93, 93–99

github-actions · 2024-04-10T08:07:02Z

Coverage after merging add-helm-chart into main will be

53.33%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
ArcaneEnvironment.cs	0%	100%	0%	0%	10, 5, 8–9
src/Extensions
JsonElementExtensions.cs	0%	100%	0%	0%	20
V1JobExtensions.cs	85.58%	75%	90.91%	90.16%	40, 40, 45, 61–62, 62, 62, 62, 62–65, 83, 83
src/Models/StreamClass
V1Beta1StreamClassSpec.cs	20%	100%	20%	20%	11, 17, 23, 29
src/Models/StreamClass/Base
IStreamClass.cs	0%	100%	0%	0%	44–49
src/Models/StreamDefinitions/Base
IStreamDefinition.cs	90%	83.33%	100%	100%	28
src/Models/StreamStatuses/StreamStatus/V1Beta1
V1Beta1StreamStatus.cs	100%	100%	100%	100%
src/Services
StreamInteractionService.cs	0%	100%	0%	0%	16–19, 23–27, 31–35, 39–45
src/Services/Maintenance
HostedStreamingJobMaintenanceService.cs	0%	0%	0%	0%	16–24, 27–29, 29, 29–36, 39–42
StreamingJobMaintenanceService.cs	89.84%	82.14%	100%	91.40%	104–107, 122, 131–134, 136, 62, 67, 98
src/Services/Operator
HostedStreamOperatorService.cs	82.14%	100%	66.67%	82.61%	39–42
StreamClassOperatorService.cs	70.30%	40%	75%	73.49%	107–110, 116, 121–122, 127–130, 74, 74, 77, 79, 84–86, 86, 86–91, 97–99
StreamOperatorService.cs	93.47%	87.04%	100%	95.65%	107–113, 118, 126, 140, 140, 146, 168
StreamOperatorServiceWorker.cs	77.78%	50%	75%	80%	47–51, 56, 64
StreamOperatorServiceWorkerFactory.cs	100%	100%	100%	100%
src/Services/Repositories
StreamDefinitionRepository.cs	0%	0%	0%	0%	100–111, 22–29, 32–34, 34, 34–49, 53–55, 55, 55–76, 79–81, 81, 81–93, 96–98, 98, 98–99
StreamingJobTemplateRepository.cs	0%	0%	0%	0%	20–27, 31–33, 33, 33, 33, 33, 33, 33, 33, 33–36, 39–47
src/Services/Streams
StreamingJobOperatorService.cs	0%	0%	0%	0%	100–107, 110–113, 113, 113–115, 118–121, 121, 121–123, 126–129, 129, 129–131, 134–137, 140–146, 150–152, 152, 152, 152, 152–155, 155, 155, 155, 155–156, 158–161, 163–169, 173, 173, 173, 173, 173–179, 182–188, 191–200, 31–43, 46, 49–56, 59–60, 60, 60–63, 63, 63–70, 70, 70–90, 90, 90, 90, 90–93, 93, 93–99

s-vitaliy added 2 commits April 8, 2024 15:00

WIP

9a606f4

Add the Helm Chart for Arcane Operator

c4bb2e6

s-vitaliy requested a review from a team as a code owner April 8, 2024 14:35

Merge branch 'main' into add-helm-chart

91e56b0

s-vitaliy added 4 commits April 8, 2024 16:38

Self-review fix

71f76c7

Self-review fix

a38aa10

Merge remote-tracking branch 'origin/add-helm-chart' into add-helm-chart

8e4de7a

Self-review fix

d3db30a

george-zubrienko reviewed Apr 9, 2024

View reviewed changes

Merge branch 'main' into add-helm-chart

b7c6519

s-vitaliy requested a review from george-zubrienko April 9, 2024 08:35

s-vitaliy added 4 commits April 9, 2024 10:52

Merge branch 'main' into add-helm-chart

5868850

Review fixes

f513f1a

Merge remote-tracking branch 'origin/add-helm-chart' into add-helm-chart

c49b8dc

Build fix

9336249

Review fixes

4a98d8c

george-zubrienko approved these changes Apr 9, 2024

View reviewed changes

Merge branch 'main' into add-helm-chart

39ed1f9

Merge branch 'main' into add-helm-chart

a763927

s-vitaliy merged commit e768738 into main Apr 10, 2024
2 checks passed

s-vitaliy deleted the add-helm-chart branch April 10, 2024 08:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add helm chart #19

Add helm chart #19

s-vitaliy commented Apr 8, 2024

github-actions bot commented Apr 8, 2024

github-actions bot commented Apr 8, 2024

github-actions bot commented Apr 8, 2024

github-actions bot commented Apr 8, 2024

george-zubrienko left a comment

george-zubrienko Apr 9, 2024

george-zubrienko Apr 9, 2024

s-vitaliy Apr 9, 2024

george-zubrienko Apr 9, 2024

s-vitaliy Apr 9, 2024

george-zubrienko Apr 9, 2024

s-vitaliy Apr 9, 2024

george-zubrienko Apr 9, 2024

s-vitaliy Apr 9, 2024

george-zubrienko Apr 9, 2024

s-vitaliy Apr 9, 2024

george-zubrienko Apr 9, 2024

s-vitaliy Apr 9, 2024

george-zubrienko Apr 9, 2024

s-vitaliy Apr 9, 2024

github-actions bot commented Apr 9, 2024

github-actions bot commented Apr 9, 2024

github-actions bot commented Apr 9, 2024

github-actions bot commented Apr 10, 2024

github-actions bot commented Apr 10, 2024

Add helm chart #19

Add helm chart #19

Conversation

s-vitaliy commented Apr 8, 2024

Scope

Checklist

github-actions bot commented Apr 8, 2024

github-actions bot commented Apr 8, 2024

github-actions bot commented Apr 8, 2024

github-actions bot commented Apr 8, 2024

george-zubrienko left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Apr 9, 2024

github-actions bot commented Apr 9, 2024

github-actions bot commented Apr 9, 2024

github-actions bot commented Apr 10, 2024

github-actions bot commented Apr 10, 2024