Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic Merge/Overwrite Query interface #100

Merged
merged 22 commits into from
Dec 3, 2024
Merged

Conversation

george-zubrienko
Copy link
Contributor

@george-zubrienko george-zubrienko commented Nov 28, 2024

Part of #61

Scope

Implemented:

  • Ported SQL query generation from PySpark (Delta) and generalised it to work for across different sources
  • Added skeleton for executing batch merges via Sql (jdbc) - more work to follow in the next PR

Checklist

  • Unit tests added and they pass.

@george-zubrienko george-zubrienko changed the title Trino merge Generic Merge/Overwrite Query interface Nov 28, 2024
@george-zubrienko george-zubrienko changed the base branch from main to scala November 28, 2024 17:04
@george-zubrienko george-zubrienko marked this pull request as ready for review November 29, 2024 10:26
@george-zubrienko george-zubrienko requested a review from a team as a code owner November 29, 2024 10:26
Copy link
Contributor

@s-vitaliy s-vitaliy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, with some comments

Copy link

github-actions bot commented Dec 3, 2024

File Coverage
All files 62%
models/ArcaneSchema.scala 61%
models/app/StreamContext.scala 0%
models/querygen/MergeQuery.scala 85%
services/app/PosixStreamLifetimeService.scala 0%
services/app/StreamRunnerServiceImpl.scala 0%
services/app/logging/Enrichers.scala 0%
services/app/logging/Enrichers.scala 0%
services/app/logging/Enrichers.scala 0%
services/app/logging/base/Enricher.scala 0%
services/consumers/JdbcConsumer.scala 0%
services/consumers/JdbcConsumer.scala 0%
services/lakehouse/IcebergS3CatalogWriter.scala 0%
services/lakehouse/IcebergS3CatalogWriter.scala 80%
services/lakehouse/IcebergCatalogCredential.scala 56%
services/lakehouse/SchemaConversions.scala 28%
services/mssql/MsSqlDataProvider.scala 87%
services/mssql/MsSqlDataProvider.scala 82%
services/mssql/MsSqlConnection.scala 75%
services/mssql/MsSqlConnection.scala 64%
services/mssql/query/LazyQueryResult.scala 79%
services/mssql/query/ScalarQueryResult.scala 66%
services/storage/models/amazon/AmazonS3StoragePath.scala 80%
services/streaming/BackfillGroupingProcessor.scala 0%
services/streaming/VersionedDataGraphBuilder.scala 66%
services/streaming/BackfillDataGraphBuilder.scala 0%

Minimum allowed coverage is 40%

Generated by 🐒 cobertura-action against 4a5bf3e

@george-zubrienko george-zubrienko merged commit 7d40ab2 into scala Dec 3, 2024
3 checks passed
@george-zubrienko george-zubrienko deleted the trino-merge branch December 3, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants