Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor QueryProvider #107

Merged
merged 8 commits into from
Dec 4, 2024
Merged

Refactor QueryProvider #107

merged 8 commits into from
Dec 4, 2024

Conversation

s-vitaliy
Copy link
Contributor

@s-vitaliy s-vitaliy commented Dec 4, 2024

Part of #61

Scope

Implemented:

Checklist

  • GitHub issue exists for this change.
  • Unit tests added and they pass.
  • Line Coverage is at least 80%.
  • Review requested on latest commit.

@s-vitaliy s-vitaliy marked this pull request as ready for review December 4, 2024 10:08
@s-vitaliy s-vitaliy requested a review from a team as a code owner December 4, 2024 10:08
Copy link

github-actions bot commented Dec 4, 2024

File Coverage
All files 58%
models/ArcaneSchema.scala 61%
models/app/StreamContext.scala 0%
models/querygen/MergeQuery.scala 85%
models/querygen/InitializeQuery.scala 0%
services/app/PosixStreamLifetimeService.scala 0%
services/app/StreamRunnerServiceImpl.scala 0%
services/app/logging/Enrichers.scala 0%
services/app/logging/Enrichers.scala 0%
services/app/logging/Enrichers.scala 0%
services/app/logging/base/Enricher.scala 0%
services/consumers/SqlServerChangeTracking.scala 86%
services/consumers/JdbcConsumer.scala 0%
services/consumers/JdbcConsumer.scala 0%
services/consumers/SqlServerChangeTracking.scala 88%
services/lakehouse/IcebergS3CatalogWriter.scala 0%
services/lakehouse/IcebergS3CatalogWriter.scala 78%
services/lakehouse/IcebergCatalogCredential.scala 56%
services/lakehouse/SchemaConversions.scala 28%
services/mssql/MsSqlDataProvider.scala 87%
services/mssql/MsSqlDataProvider.scala 82%
services/mssql/QueryProvider.scala 77%
services/mssql/MsSqlConnection.scala 64%
services/mssql/query/ScalarQueryResult.scala 66%
services/mssql/query/LazyQueryResult.scala 79%
services/storage/models/amazon/AmazonS3StoragePath.scala 80%
services/streaming/IcebergConsumer.scala 0%
services/streaming/BackfillGroupingProcessor.scala 0%
services/streaming/VersionedDataGraphBuilder.scala 66%
services/streaming/BackfillDataGraphBuilder.scala 0%

Minimum allowed coverage is 40%

Generated by 🐒 cobertura-action against 0a0ed9a

@s-vitaliy s-vitaliy changed the title Add missing tests to query provider Refactor QueryProvider Dec 4, 2024
@s-vitaliy s-vitaliy merged commit 5ba4210 into scala Dec 4, 2024
3 checks passed
@s-vitaliy s-vitaliy deleted the add-query-provider-tests branch December 4, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants