Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDM (Synapse Link for Dynamics) plugin #118

Merged
merged 14 commits into from
Dec 16, 2024
Merged

Conversation

george-zubrienko
Copy link
Contributor

CDM Plugin WIP

Copy link

github-actions bot commented Dec 10, 2024

File Coverage
All files 66%
models/app/StreamContext.scala 0%
models/cdm/SimpleCdmModel.scala 88%
models/cdm/CdmParser.scala 91%
models/cdm/SimpleCdmModel.scala 67%
models/querygen/MergeQuery.scala 85%
models/querygen/InitializeQuery.scala 0%
services/app/PosixStreamLifetimeService.scala 0%
services/app/StreamRunnerServiceImpl.scala 0%
services/app/logging/Enrichers.scala 0%
services/app/logging/Enrichers.scala 0%
services/app/logging/Enrichers.scala 0%
services/app/logging/base/Enricher.scala 0%
services/cdm/CdmTable.scala 95%
services/consumers/SqlServerChangeTracking.scala 86%
services/consumers/JdbcConsumer.scala 0%
services/consumers/JdbcConsumer.scala 0%
services/consumers/SqlServerChangeTracking.scala 88%
services/lakehouse/IcebergS3CatalogWriter.scala 0%
services/lakehouse/IcebergS3CatalogWriter.scala 78%
services/lakehouse/IcebergCatalogCredential.scala 56%
services/lakehouse/SchemaConversions.scala 28%
services/mssql/MsSqlDataProvider.scala 87%
services/mssql/MsSqlDataProvider.scala 82%
services/mssql/QueryProvider.scala 77%
services/mssql/MsSqlConnection.scala 64%
services/mssql/query/LazyQueryResult.scala 79%
services/mssql/query/ScalarQueryResult.scala 66%
services/storage/models/amazon/AmazonS3StoragePath.scala 80%
services/storage/models/azure/AzureModelConversions.scala 98%
services/storage/models/azure/AzureBlobStorageReader.scala 60%
services/storage/models/azure/AdlsStoragePath.scala 76%
services/storage/models/base/StoredBlob.scala 0%
services/streaming/base/StreamGraphBuilder.scala 0%
services/streaming/consumers/IcebergStreamingConsumer.scala 0%
services/streaming/consumers/IcebergBackfillConsumer.scala 0%
services/streaming/graph_builders/VersionedDataGraphBuilder.scala 66%
services/streaming/graph_builders/BackfillDataGraphBuilder.scala 0%
services/streaming/processors/BackfillGroupingProcessor.scala 0%
services/streaming/processors/MergeProcessor.scala 0%

Minimum allowed coverage is 40%

Generated by 🐒 cobertura-action against 8915e2b

Copy link
Contributor

@s-vitaliy s-vitaliy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment related to readability

Copy link
Contributor

@s-vitaliy s-vitaliy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general added one question.

@george-zubrienko george-zubrienko marked this pull request as ready for review December 12, 2024 15:47
@george-zubrienko george-zubrienko requested a review from a team as a code owner December 12, 2024 15:47
@george-zubrienko george-zubrienko changed the title WIP CDM table read CDM (Synapse Link for Dynamics) plugin Dec 12, 2024
@george-zubrienko george-zubrienko merged commit 3a72b49 into scala Dec 16, 2024
3 checks passed
@george-zubrienko george-zubrienko deleted the synapse-plugin branch December 16, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants