Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change shader build integration to be compatible with zig 0.13.0 #154

Closed
wants to merge 1 commit into from

Conversation

moomba42
Copy link

@moomba42 moomba42 commented Aug 8, 2024

Running shader compilation with zig version 0.13.0 was throwing the following error:

/src/build_integration.zig:168:51: error: root struct of file 'Build.Step' has no member named 'MakeOptions'
    fn make(step: *Build.Step, options: Build.Step.MakeOptions) !void {
                                        ~~~~~~~~~~^~~~~~~~~~~~

This small change fixes that, but makes the library incompatible with previous zig versions.

@Snektron
Copy link
Owner

Snektron commented Aug 8, 2024

Current vulkan-zig is compatible with the master branch of Zig. The exact reverse of this merge request was made a few weeks ago: #152. I've pushed a zig-0.13-compat branch for you that you should be able to use.

@moomba42
Copy link
Author

moomba42 commented Aug 8, 2024

Oh I see, thank you very much :) I'm closing this then.

@moomba42 moomba42 closed this Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants