Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update for latest zig #157

Merged
merged 2 commits into from
Sep 1, 2024
Merged

update for latest zig #157

merged 2 commits into from
Sep 1, 2024

Conversation

andrewrk
Copy link
Contributor

No description provided.

Integrate with tooling and makes the package size smaller.
@andrewrk
Copy link
Contributor Author

andrewrk commented Aug 31, 2024

(unrelated to the PR)

check it out, I adapted the example to use xcb directly rather than glfw:

image

source

btw I think the custom build step (ShaderCompileStep) would be better off as a Run step. You can still provide the same API but it will be less fragile to use the existing std lib Run step.

handy package btw :)

@Snektron
Copy link
Owner

Nice! Yes, I've been meaning to get rid of the ShaderCompileSteps entirely.

Looks like is one instance of the old names remaining in test/ref_all_decls.zig, should be good otherwise.

@andrewrk
Copy link
Contributor Author

andrewrk commented Sep 1, 2024

Hmm, how come I can't trigger this with zig build test?

andy@bark ~/s/vulkan-zig (master)> zig build test --summary all
Build Summary: 3/3 steps succeeded; 9/9 tests passed
test success
└─ run test 9 passed 1ms MaxRSS:2M
   └─ zig test Debug native success 1s MaxRSS:290M
andy@bark ~/s/vulkan-zig (master)> zig version
0.14.0-dev.1392+37df6ba86

Edit: I see, I need the registry option enabled.

@Snektron Snektron merged commit f7b21d0 into Snektron:master Sep 1, 2024
1 check passed
@Snektron
Copy link
Owner

Snektron commented Sep 1, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants