Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unused password attribute when authenticating via externalbrowser #292

Closed
wants to merge 1 commit into from
Closed

fix: remove unused password attribute when authenticating via externalbrowser #292

wants to merge 1 commit into from

Conversation

zanebclark
Copy link

Closes bug Bug 289

@zanebclark zanebclark mentioned this pull request Oct 17, 2024
Open
@zanebclark
Copy link
Author

@sfc-gh-tmathew @jamesweakley @sfc-gh-jhansen, a pretty easy fix

sfc-gh-jhansen
sfc-gh-jhansen reviewed Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-jhansen sfc-gh-jhansen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please see my comments on #285 about getting the tests to pass.

@zanebclark
Copy link
Author

@sfc-gh-jhansen , how mortifying! This should address the failures seen on #285.

@zanebclark
Copy link
Author

@sfc-gh-tmathew and @sfc-gh-jhansen, flagging a few 4.0.0 candidates.

@zanebclark
Copy link
Author

Closing in favor of #298

@zanebclark zanebclark closed this Nov 18, 2024
@zanebclark zanebclark deleted the bug/externalbrowser_ignores_password branch November 18, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-jhansen sfc-gh-jhansen sfc-gh-jhansen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zanebclark @sfc-gh-jhansen