Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Alistair Singh <alistair.singh7@gmail.com>
  • Loading branch information
vgeddes and alistair-singh authored Dec 10, 2024
1 parent fc48f45 commit e35cd91
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion contracts/src/Initializer.sol
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,10 @@ library Initializer {
UD60x18 multiplier;
/// @dev Optional rescueOperator
address rescueOperator;
/// @dev The WETH address used for wrapping ETH
address weth;
uint8 foreignTokenDecimals;
uint128 maxDestinationFee;
address weth;
}

function initialize(bytes calldata data) external {
Expand Down
2 changes: 1 addition & 1 deletion contracts/src/storage/AssetsStorage.sol
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,14 @@ library AssetsStorage {
uint256 registerTokenFee;
// Foreign token registry by token ID
mapping(bytes32 foreignID => address) tokenAddressOf;
address weth;
uint8 foreignTokenDecimals;
// The maximum fee that can be sent to a destination parachain to pay for execution (DOT).
// Has two functions:
// * Reduces the ability of users to perform arbitrage using a favourable exchange rate
// * Prevents users from mistakenly providing too much fees, which would drain AssetHub's
// sovereign account here on Ethereum.
uint128 maxDestinationFee;
address weth;
}

bytes32 internal constant SLOT = keccak256("org.snowbridge.storage.assets");
Expand Down

0 comments on commit e35cd91

Please sign in to comment.