Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pumpkin-inventory/src/drag_handler.rs): divide by 0 #393

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

DataM0del
Copy link
Contributor

Please work
Also, commit made on mobile using Built-in GitHub editor 🔥

Description

Fixes #386
Screenshot_20241211-001233

Testing

Checklist

Things need to be done before this Pull Request can be merged.

  • Code is well-formatted and adheres to project style guidelines: cargo fmt
  • Code does not produce any clippy warnings: cargo clippy
  • All unit tests pass: cargo test

Please work
Also, commit made on mobile using Built-in GitHub editor 🔥
@DataM0del
Copy link
Contributor Author

dies from failing CI

@DataM0del
Copy link
Contributor Author

Most unrelated CI fail on earth

@DataM0del DataM0del marked this pull request as ready for review December 11, 2024 06:27
@DataM0del
Copy link
Contributor Author

All lint errors are in pumpkin-protocol, which this PR doesn't change anything in

@DataM0del
Copy link
Contributor Author

Screenshot_20241211-003010

@lucas11222
Copy link
Contributor

Please work Also, commit made on mobile using Built-in GitHub editor 🔥

Description

Fixes #386 Screenshot_20241211-001233

Testing

Checklist

Things need to be done before this Pull Request can be merged.

* [x]  Code is well-formatted and adheres to project style guidelines: `cargo fmt`

* [x]  Code does not produce any clippy warnings: `cargo clippy`

* [x]  All unit tests pass: `cargo test`

you are crazy. programing in a PHONE

@DataM0del
Copy link
Contributor Author

you are crazy. programing in a PHONE

wdym it's just wrapping something around a if statement and returning different values based on that

@Snowiiii
Copy link
Owner

like already asked in #386. I'm still not sure how to reproduce a bug with the current code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Divide by zero with some container actions
3 participants