fix: maintenance issues

clients/firebase.client.ts

@@ -470,8 +470,8 @@ export function observeDerniersMessagesDuChat(
         limit(nbMessages)
       ),
       (querySnapshot: QuerySnapshot<FirebaseMessage, FirebaseMessage>) => {
-        const messages: Message[] = querySnapshot.docs.map((doc) =>
-          docSnapshotToMessage(doc, beneficiaireEtChat.id)
+        const messages: Message[] = querySnapshot.docs.map((docSnapshot) =>
+          docSnapshotToMessage(docSnapshot, beneficiaireEtChat.id)
         )
         if (messages.length && !messages.at(-1)!.creationDate) {
           return
@@ -567,8 +567,8 @@ export async function getMessagesPeriode(
       )
     )
 
-  return querySnapshots.docs.map((doc) =>
-    docSnapshotToMessage(doc, beneficiaireEtChat.id)
+  return querySnapshots.docs.map((docSnapshot) =>
+    docSnapshotToMessage(docSnapshot, beneficiaireEtChat.id)
   )
 }
 

components/__mocks__/ModalContainer.tsx

@@ -1,23 +1,9 @@
-import {
-  ForwardedRef,
-  forwardRef,
-  MouseEvent,
-  ReactNode,
-  useImperativeHandle,
-} from 'react'
+import { ForwardedRef, forwardRef, useImperativeHandle } from 'react'
 
-import { ModalHandles } from 'components/Modal'
+import { ModalContainerProps, ModalHandles } from 'components/ModalContainer'
 
 function FakeModalContainer(
-  {
-    children,
-    title,
-    onClose,
-  }: {
-    title: string
-    children: ReactNode
-    onClose: (e: KeyboardEvent | MouseEvent) => void
-  },
+  { children, onClose }: ModalContainerProps,
   ref: ForwardedRef<ModalHandles>
 ) {
   useImperativeHandle(ref, () => ({

components/chat/LienAction.tsx

@@ -1,8 +1,7 @@
 import Link from 'next/link'
 import React from 'react'
 
-import { InfoAction, InfoOffre } from 'interfaces/message'
-import { TypeOffre } from 'interfaces/offre'
+import { InfoAction } from 'interfaces/message'
 
 export default function LienAction({
   infoAction,

interfaces/message.ts

@@ -132,6 +132,4 @@ export function getPreviousItemId<T extends { id: string }>(
     if (previousDay.messages.length) return previousDay.messages.at(-1)!.id // dernier item du 1er jour précédent avec des items
     indexPreviousDay--
   }
-
-  return
 }

services/messages.service.ts

@@ -11,9 +11,10 @@ import {
   CreateFirebaseMessagePartageOffre,
   deleteMessageImportant,
   findAndObserveChatsDuConseiller,
+  findMessageImportant,
+  getChatDuBeneficiaire,
   getChatsDuConseiller,
   getIdLastMessage,
-  findMessageImportant,
   getMessagesGroupe,
   getMessagesPeriode,
   observeChat,
@@ -23,7 +24,6 @@ import {
   signOut as _signOut,
   updateChat,
   updateMessage,
-  getChatDuBeneficiaire,
 } from 'clients/firebase.client'
 import { Action } from 'interfaces/action'
 import {
@@ -599,15 +599,15 @@ async function envoyerCommentaireAction(
 
   await Promise.all([
     notifierNouveauMessage(
-      session!.user.id,
+      session.user.id,
       [idDestinataire],
-      session!.accessToken
+      session.accessToken
     ),
     evenementMessage(
       'MESSAGE_ACTION_COMMENTEE',
-      session!.user.structure,
-      session!.user.id,
-      session!.accessToken
+      session.user.structure,
+      session.user.id,
+      session.accessToken
     ),
   ])
 }

tests/components/ActualitesModal.test.tsx

@@ -58,7 +58,7 @@ describe('ActualitesModal', () => {
           level: 3,
           name: 'Invitation à la journée présentiel du 31 octobre 2024',
         })
-      )
+      ).toBeInTheDocument()
       expect(screen.getByText('Catégorie')).toBeInTheDocument()
       expect(
         screen.getByText('Rdv demain aux nouveaux locaux de la Fabrique')