Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

feat: yarn berry + yarn fetch + docker opti #178

Merged
merged 50 commits into from
Aug 17, 2023

Conversation

devthejo
Copy link
Member

same as #177
but for hasura branch

@devthejo devthejo requested a review from a team as a code owner August 14, 2023 14:34
@gitguardian
Copy link

gitguardian bot commented Aug 14, 2023

⚠️ GitGuardian has uncovered 8 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
3513932 Generic High Entropy Secret 037796f .github/workflows/e2e.yml View secret
3513932 Generic High Entropy Secret c576a17 .github/workflows/e2e.yml View secret
3513932 Generic High Entropy Secret 84bd3b1 .github/workflows/e2e.yml View secret
3513932 Generic High Entropy Secret 50bded2 .github/workflows/e2e.yml View secret
3513932 Generic High Entropy Secret 981809e .github/workflows/e2e.yml View secret
3513932 Generic High Entropy Secret 8b2d057 .github/workflows/e2e.yml View secret
3513932 Generic High Entropy Secret 8b2d057 .github/workflows/e2e.yml View secret
3513932 Generic High Entropy Secret 5af1d3a .github/workflows/e2e.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@socket-security
Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@codegouvfr/react-dsfr 0.73.2...0.73.7 None +0/-0 66.1 MB garronej
@babel/core 7.22.9...7.22.10 None +13/-12 8.95 MB nicolo-ribaudo
@mui/x-data-grid 5.17.22...5.17.26 None +7/-9 8.92 MB alexandrefauquette
@mui/x-date-pickers 5.0.17...5.0.20 None +11/-13 6.39 MB cherniavskii
storybook-dark-mode 2.0.5...2.1.1 None +3/-1 373 kB alisowski
hasura-cli 2.30.0...2.31.0 None +0/-0 22.2 kB jjangga0214

@devthejo devthejo temporarily deployed to review-auto August 14, 2023 15:01 — with GitHub Actions Inactive
@sonarcloud
Copy link

sonarcloud bot commented Aug 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

🎉 Deployment for commit c851b63 :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/fabrique/template/app:sha-c851b63b6df3942bcd5088e5fed6dd93a5f96183
  • 📦 docker pull harbor.fabrique.social.gouv.fr/fabrique/template/hasura:sha-c851b63b6df3942bcd5088e5fed6dd93a5f96183
  • 📦 docker pull maildev/maildev:2.1.0
  • 📦 docker pull sosedoff/pgweb:0.14.1
Debug

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@devthejo devthejo merged commit c4f71e9 into hasura Aug 17, 2023
20 checks passed
@devthejo devthejo deleted the fix/optimize-dockerfile-branch-hasura branch August 17, 2023 16:32
@SocialGroovyBot
Copy link
Member

🎉 This PR is included in version 1.16.0-hasura.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants