Update Azure ADB2C for OpenId differences #1171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atymic
reviewed
Mar 12, 2024
| @@ -198,11 +204,18 @@ private function validateIdToken($idToken) | |||
| */ | |||
| protected function mapUserToObject(array $user) | |||
| { | |||
| //check is $user['email'] is array - it shouldn't be, but we are not sure | |||
| if (is_array($user['email'])) { | |||
There was a problem hiding this comment.
I guess we should also make sure this is not empty? Or alt, just do
$user['email'][0] ?? $user['email']
There was a problem hiding this comment.
also good, I'll change to your line and resubmit
|
@baradhili Can you link this PR to issue #1320 so that it's closed automatically once this PR is merged? To do this, you just need to add the following to the end of the PR description: fixes #1320 |
|
Looks like master has updated to handle this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to work for me. Have included URL I relied on for scope space separator as well as handling if the $user['email'] is an array or not since there is no spec from MS saying it will always be a scalar
fixes #1320