feat: Create Hero Section #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chewmanji
requested changes
Nov 25, 2024
src/app/components/HeroSection.tsx
Outdated
| </div> | ||
| <div className="flex flex-col md:flex-row justify-center gap-4 text-[1.125rem]" ref={animateContainerRef}> | ||
| <button className="px-5 py-4 bg-[var(--color-white)] text-[#010840] rounded-xl"> | ||
| <a className="flex justify-center items-center gap-2" href="">Wypróbuj <ArrowUpRight size={32} color="#010840" /></a> |
There was a problem hiding this comment.
As we use NextJS we should use NextJS Link component for navigation imo
src/app/components/HeroSection.tsx
Outdated
| <p className="text-[clamp(1.2rem,2cqw,1.75rem)] max-w-screen-md mx-auto pt-8" > Nasz system rekomendacyjny dopasuje go do tytułu lub opisu twojej pracy dyplomowej. </p> | ||
| </div> | ||
| <div className="flex flex-col md:flex-row justify-center gap-4 text-[1.125rem]" ref={animateContainerRef}> | ||
| <button className="px-5 py-4 bg-[var(--color-white)] text-[#010840] rounded-xl"> |
There was a problem hiding this comment.
Can we use shadcn components for things that shadcn has comoponents for?
src/app/globals.css
Outdated
Comment on lines
32
to
33
| --color-white: #E7EAFB; | ||
| --color-primary: #5F7ECD; |
There was a problem hiding this comment.
I think that if we will move these to tailwind.cofnig.ts it will be easier to use in code
package.json
Outdated
| @@ -11,6 +11,7 @@ | |||
| "dependencies": { | |||
| "class-variance-authority": "^0.7.0", | |||
| "clsx": "^2.1.1", | |||
| "gsap": "^3.12.5", | |||
There was a problem hiding this comment.
I think it will be better to first create app without any animations and then add them
…o tailwing.config
chewmanji
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.