Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on Half only where obsolete #27

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

dabrahams
Copy link
Contributor

@dabrahams dabrahams commented Nov 13, 2023

Description

This is just #21 but with Half still in use on x64 Macs. I need to remove the Half dependency in order to run on Windows but unfortunately x64 Macs (only!) don't support Float16.

Fixes #29 by avoiding SomeRandomiOSDev/Half#16

Checklist

Ensure that your pull request has followed all the steps below:

  • Code compilation.
  • All tests passing.
  • No new SwiftLint issues.
  • Added new unit tests, if applicable.
  • Extended the documentation (including README), if applicable.
  • Updated version in CBORCoding.podspec following semver guidelines.
  • Ran workflowtests.sh and passed.
  • Added myself to the CONTRIBUTORS file.

workflowtests.sh fails, but it already fails for me on yourmain branch. I'll report a separate issue.
I'm already in CONTRIBUTORS.md

Proposed changes

In addition to the motivation above, see #21.

@SomeRandomiOSDev
Copy link
Owner

@dabrahams I created a release to address a lot of the issues that came up due to this repo being so out of date. Please rebase on this release and update this PR accordingly

Otherwise it gets deleted from Package.resolved
@christophhagen christophhagen mentioned this pull request Nov 15, 2023
8 tasks
@dabrahams
Copy link
Contributor Author

@SomeRandomiOSDev Rebasing is going to be tough. I'm just trying to get as far as making a merge work; I'm not an Xcode/carthage/cocoapods/whatever jock, so making all those parts work is a challenge for me. It's not clear whether you're willing to accept the minimum deployment targets advancing considerably in order to get Float16 supported, but that's what @christophhagen seems to have assumed and I'm following the same pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: swift test is failing on Linux
3 participants