SLCORE-999 Store custom impacts when synchronizing rules #1141
Conversation
eray-felek-sonarsource
force-pushed
the
feature/ef/SLCORE-999-store-custom-impacts
branch
from
ec233e2
to
1294390
Compare
backend/core/src/main/java/org/sonarsource/sonarlint/core/analysis/AnalysisService.java
Show resolved
Hide resolved
backend/core/src/main/java/org/sonarsource/sonarlint/core/analysis/AnalysisService.java
Show resolved
Hide resolved
backend/core/src/main/java/org/sonarsource/sonarlint/core/rules/RulesService.java
Show resolved
Hide resolved
backend/core/src/main/java/org/sonarsource/sonarlint/core/rules/RulesService.java
Show resolved
Hide resolved
| return new ServerActiveRule(ruleOrTemplateDefinition.get().getKey(), possiblyDeprecatedActiveRuleFromStorage.getSeverity(), | ||
| possiblyDeprecatedActiveRuleFromStorage.getParams(), | ||
| null, Collections.emptyList()); | ||
| null, possiblyDeprecatedActiveRuleFromStorage.getOverriddenImpacts()); | ||
| } |
There was a problem hiding this comment.
This method is very similar to the one in AnalysisService, maybe there is a way to keep only one
There was a problem hiding this comment.
How about making it static on RuleService and using it on AnalysisService?
eray-felek-sonarsource
force-pushed
the
feature/ef/SLCORE-999-store-custom-impacts
branch
from
1294390
to
fc21718
Compare
eray-felek-sonarsource
force-pushed
the
feature/ef/SLCORE-999-store-custom-impacts
branch
2 times, most recently
from
282bd48
to
9de7393
Compare
backend/core/src/main/java/org/sonarsource/sonarlint/core/rules/RuleDetails.java
Outdated
Show resolved
Hide resolved
| @@ -147,11 +149,25 @@ public static RuleDetails merging(ServerActiveRule activeRuleFromStorage, Server | |||
| serverRule.getSeverity(), | |||
| templateRuleDefFromPlugin.getType(), | |||
| cleanCodeAttribute, | |||
| defaultImpacts, | |||
| mergeImpacts(defaultImpacts, activeRuleFromStorage.getOverriddenImpacts()), | |||
There was a problem hiding this comment.
I missed that ServerActiveRule.getOverridenImpacts() returns a List<ImpactPayload>. This is strange since ImpactPayload comes from org.sonarsource.sonarlint.core.serverapi.push.parsing.common, which is related to the payload of server events. We should maybe have a separate type for the storage. Maybe an improvement for later
There was a problem hiding this comment.
I agree it can be improvement for later. Created this ticket to track: https://sonarsource.atlassian.net/browse/SLCORE-1021
backend/core/src/test/java/org/sonarsource/sonarlint/core/rules/RulesServiceTests.java
Outdated
Show resolved
Hide resolved
eray-felek-sonarsource
force-pushed
the
feature/ef/SLCORE-999-store-custom-impacts
branch
from
9de7393
to
576c7a1
Compare
|
eray-felek-sonarsource
merged commit 1bf8dcf
into
mmf/SLCORE-959-custom-severities
eray-felek-sonarsource
deleted the
feature/ef/SLCORE-999-store-custom-impacts
branch
SLCORE-999