Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLCORE-927 Reactivate git blaming for bare repositories #1142

Conversation

serhat-yenican-sonarsource
Copy link
Contributor

@serhat-yenican-sonarsource serhat-yenican-sonarsource commented Oct 31, 2024

SLCORE-927

For SonarSourcers:

  • Prefix the commit message with the ticket number, i.e. SLCORE-XXXX if you already have a ticket in Jira
  • For standalone PRs without issue in Jira:
    • Mention Epic ID in this descrition to create a new Task in Jira
    • Mention Issue ID in this descrition to create a new Sub-Task in Jira
    • Do not mention any Jira issue to create a new Task in Jira without a parent
  • When changing an API:
    • Explain in the JavaDoc the purpose of the new API
    • Document the change in API_CHANGES.md
    • If the change breaks the current API, explicitly communicate those to the impacted consumers prior to merging (eg. IDE squad)
  • Make sure the tests adhere to the convention:
    • All test method names should use snake_case, for example: test_validate_input.
  • Make sure checks are green: build passes, Quality Gate is green

For external contributors:

In addition to the above, please review our contribution guidelines and ensure your pull request adheres to the following guidelines:

  • Please explain your motives to contribute this change: what problem you are trying to fix, what improvement you are trying to make
  • Use the following formatting style: SonarSource/sonar-developer-toolset
  • Provide a unit test for any code you changed

Copy link
Contributor

@kirill-knize-sonarsource kirill-knize-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serhat-yenican-sonarsource serhat-yenican-sonarsource merged commit 427d4d6 into master Nov 4, 2024
14 checks passed
@serhat-yenican-sonarsource serhat-yenican-sonarsource deleted the feature/serhat/SLCORE-927-Reactivate-git-blaming-for-bare-repositories-after-git-files-blame-support branch November 4, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants