SLE-920: Enhance the extension point for diff viewers #723
Conversation
Enhance the extension point used for syntax highlighting with a new method to take into account the compare/diff viewer. Added implementations for JDT (Java/JSP) and CDT (C/C++) but not PyDev due to a missing `Export-Package` statement in the plug-in.
| @@ -14,7 +14,9 @@ Require-Bundle: org.eclipse.core.runtime, | |||
| org.sonarlint.eclipse.core, | |||
| org.eclipse.core.filesystem, | |||
| org.eclipse.jdt.annotation;resolution:=optional, | |||
| org.eclipse.text | |||
| org.eclipse.text, | |||
There was a problem hiding this comment.
what do these lines do? just curious
There was a problem hiding this comment.
It is basically the Eclipse way of defining dependencies at runtime (and therefore also compile time).
The MANIFEST.MF and specifically this section will contain all bundles that we require at the runtime of the Eclipse installation. Most of them are present due to them being part of the Eclipse platform itself, but for some we have an optional.
E.g. here we have the org.eclipse.cdt.core;resolution:=optional statement that more or less is used for us to only make use of this very sub-plugin if CDT (the C development tools) are installed.
What I added is the compare bundle that brings in the TextMergeViewer and SWT that is the UI system of Eclipse.
...arlint.eclipse.cdt/src/org/sonarlint/eclipse/cdt/internal/CProjectConfiguratorExtension.java
Outdated
Show resolved
Hide resolved
In order to not calculate SWT for all fragments (Sloop) of the CORE plug-in, we move it to the UI plug-in. This will fix an error with the build as the SWT dependency couldn't be found for our "no-arch" fragment that is literally "every other OS/ARCH" combination except for the ones we have Sloop packages for.
thahnen
force-pushed
the
task/tha/SLE-920_EPs
branch
from
5394aee
to
a641499
Compare
|
Enhance the extension point used for syntax highlighting with a new method to gather language (aka plug-in) -specific implementations of the
TextMergeViewerthat is used for displaying diffs.Added implementations for JDT (Java/JSP) and CDT (C/C++) but not PyDev due to a missing
Export-Packagestatement in the plug-in.For the latter one, there is a related PR opened in fabioz/Pydev#370 but this won't be used in the feature implementation for now, but can be used later!