Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLVSCODE-896 Migrate deprecated cirrus-module v2 to v3 #636

Merged
merged 1 commit into from
Oct 31, 2024
Merged

SLVSCODE-896 Migrate deprecated cirrus-module v2 to v3 #636

merged 1 commit into from
Oct 31, 2024

Conversation

vnaskos-sonar
Copy link
Contributor

@vnaskos-sonar vnaskos-sonar commented Oct 30, 2024 •
edited by jira bot
Loading

SLVSCODE-896

  1. Update cirrus-module v2 to v3.
  2. Do not call the deprecated AWS feature method parameters subnet_id.
  3. It is recommended to not use ec2_instance or eks_container root keys.

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

sophio-japharidze-sonarsource
sophio-japharidze-sonarsource approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤷‍♀️
There are some other references to eks_container & ec2_instance in the file, just making sure they are OK to stay?

@vnaskos-sonar
Copy link
Contributor Author

LGTM 🤷‍♀️ There are some other references to eks_container & ec2_instance in the file, just making sure they are OK to stay?

Yes, those left behind are actual instructions, in contrast with the one that has been replaced, which was just a name. On v3, it is recommended not to use them as names to avoid conflicts or unexpected behavior.

@vnaskos-sonar vnaskos-sonar merged commit 05ad94c into master Oct 31, 2024
14 checks passed
@vnaskos-sonar vnaskos-sonar deleted the vn/cirrus-modules-v3 branch October 31, 2024 08:54
sophio-japharidze-sonarsource pushed a commit that referenced this pull request Nov 7, 2024
@vnaskos-sonar @sophio-japharidze-sonarsource
Migrate deprecated cirrus-module v2 to v3 (#636)
91b0e7d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophio-japharidze-sonarsource sophio-japharidze-sonarsource sophio-japharidze-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vnaskos-sonar @sophio-japharidze-sonarsource