апстрим 14/10/2024 #131
Closed
апстрим 14/10/2024 #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* moff * Attribution
Co-authored-by: PJBot <pieterjan.briers+bot@gmail.com>
* Fix some rounds failing to end due to mind roles Fixes #32791 This is caused by ShowRoundEndScoreboard running into a bug trying to display antags: some player is showing up as antag with MindIsAntagonist(), but has no antag roles listed in MindGetAllRoleInfo(). This was caused by one of the roles of the player having the Antag boolean set, but having no AntagPrototype set. The responsible mind role appeared to be MindRoleSubvertedSilicon which is missing a set for the SubvertedSilicon antag prototype. I also added resilience to the round-end code to make it so that an exception showing the scoreboard (and sending the Discord message) would not cause the round end logic to completely abort from an exception. I am planning to add an integration test to cover this bug (no prototype in mind roles), but I'll leave that for not-the-immediate-hotfix. * At least one maintainer approved this tiny PR without reading it, not naming names.
* rainbow weh * plushie loot table * arcade loot pool * remove from plushie crate * fuk
* Add role prototype validation test * Rejig GetPrototypesWithComponent * More tests n stuff
This code was a mess. Now it's less of a mess and user UserDbDataManager now. Fixes the following bugs: * If you connect to a server, restart your client, connect again in the same round, you role bans would not be visible in the client. * If you role ban somebody who is not connected to the server, then they connect within the round, they will only have the recently-applied ban. Likely fixes #24781, #27282
Updated to reflect the RecyclerVisualLayers no longer having a forward reverse or off visual effect.
* Format job requirements as hours and minutes * Use TimeSpan.ToString for playtime instead of custom method * wehflicts --------- Co-authored-by: jmcb <joelsgp@protonmail.com>
Remove inaccurate admin log when switching held item
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ради вот этого - space-wizards/space-station-14#32792
По конфликтам - отклонил space-wizards/space-station-14#32253 и добавил копирайт от space-wizards/space-station-14#32736